public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christophe Saout <christophe@saout.de>
To: Matt Mackall <mpm@selenic.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Clemens Fruhwirth <clemens@endorphin.org>,
	dm-crypt@saout.de, Alasdair G Kergon <agk@redhat.com>
Subject: Re: dm-crypt crypt_status reports key?
Date: Thu, 03 Feb 2005 14:07:48 +0100	[thread overview]
Message-ID: <1107436068.22902.12.camel@server.cs.pocnet.net> (raw)
In-Reply-To: <20050203040542.GQ2493@waste.org>

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Am Mittwoch, den 02.02.2005, 20:05 -0800 schrieb Matt Mackall:

> On Thu, Feb 03, 2005 at 03:34:29AM +0100, Christophe Saout wrote:
> > The keyring API seems very flexible. You can define your own type of
> > keys and give them names. Well, the name is probably irrelevant here and
> > should be chosen randomly but it's less likely to collide with someone
> > else.
>  
> Dunno here, seems that having one tool that gave the kernel a key named
> "foo" and then telling dm-crypt to use key "foo" is probably not a bad
> way to go. Then we don't have stuff like "echo <key> | dmsetup create"
> and the like and the key-handling smarts can all be put in one
> separate place.

Yes. I could also change cryptsetup to not mlockall the whole
application just because the key is passed down to libdevmapper which
does not treat parameters with special care.

> Getting from here to there might be interesting though. Perhaps we can
> teach dm-crypt to understand keys of the form "keyname:<foo>"? in
> addition to raw keys to keep compatibility. Might even be possible to
> push this down into crypt_decode_key() (or a smarter variant of same).
> 
> Meanwhile, I'd still like to hide the raw key in crypt_status().

Well, I don't. I don't know any tools that actually use the
DM_DEVICE_TABLE command except cryptsetup. I don't like to make the
interface inconsistent just because there might be an incompetent root
sitting in front of the machine.


[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2005-02-03 13:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 21:19 dm-crypt crypt_status reports key? Matt Mackall
2005-02-02 23:50 ` Alasdair G Kergon
2005-02-03  1:00   ` Matt Mackall
2005-02-03 21:53   ` Pavel Machek
2005-02-03  1:33 ` Christophe Saout
2005-02-03  1:52   ` Matt Mackall
2005-02-03  2:34     ` Christophe Saout
2005-02-03  4:05       ` Matt Mackall
2005-02-03 13:07         ` Christophe Saout [this message]
2005-02-03 14:18         ` Fruhwirth Clemens
2005-02-03 10:15           ` Christopher Warner
2005-02-03 15:17             ` Fruhwirth Clemens
2005-02-03 14:47           ` Andries Brouwer
2005-02-03 15:00             ` Fruhwirth Clemens
2005-02-04 13:27           ` [dm-crypt] " Fruhwirth Clemens
2005-02-04 14:03         ` Christophe Saout

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1107436068.22902.12.camel@server.cs.pocnet.net \
    --to=christophe@saout.de \
    --cc=agk@redhat.com \
    --cc=clemens@endorphin.org \
    --cc=dm-crypt@saout.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox