From: Bjorn Helgaas <bjorn-helgaas@comcast.net>
To: jgarzik@pobox.com, tulip-users@lists.sourceforge.net
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org
Subject: [PATCH] de214x.c uses uninitialized pci_dev->irq
Date: Mon, 07 Feb 2005 11:49:42 -0700 [thread overview]
Message-ID: <1107802183.8074.30.camel@piglet> (raw)
Don't use pci_dev->irq until after pci_enable_device().
Andy Esten reported that his NIC stopped working in
2.6.10 because of this problem.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
===== drivers/net/tulip/de2104x.c 1.33 vs edited =====
--- 1.33/drivers/net/tulip/de2104x.c 2004-10-25 19:04:30 -06:00
+++ edited/drivers/net/tulip/de2104x.c 2005-02-07 09:51:57 -07:00
@@ -1958,8 +1958,6 @@
dev->tx_timeout = de_tx_timeout;
dev->watchdog_timeo = TX_TIMEOUT;
- dev->irq = pdev->irq;
-
de = dev->priv;
de->de21040 = ent->driver_data == 0 ? 1 : 0;
de->pdev = pdev;
@@ -1994,6 +1992,8 @@
pdev->irq, pci_name(pdev));
goto err_out_res;
}
+
+ dev->irq = pdev->irq;
/* obtain and check validity of PCI I/O address */
pciaddr = pci_resource_start(pdev, 1);
next reply other threads:[~2005-02-07 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 18:49 Bjorn Helgaas [this message]
2005-02-11 22:09 ` [PATCH] de214x.c uses uninitialized pci_dev->irq Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107802183.8074.30.camel@piglet \
--to=bjorn-helgaas@comcast.net \
--cc=bjorn.helgaas@hp.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tulip-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox