* [PATCH] de214x.c uses uninitialized pci_dev->irq
@ 2005-02-07 18:49 Bjorn Helgaas
2005-02-11 22:09 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2005-02-07 18:49 UTC (permalink / raw)
To: jgarzik, tulip-users; +Cc: bjorn.helgaas, linux-kernel
Don't use pci_dev->irq until after pci_enable_device().
Andy Esten reported that his NIC stopped working in
2.6.10 because of this problem.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
===== drivers/net/tulip/de2104x.c 1.33 vs edited =====
--- 1.33/drivers/net/tulip/de2104x.c 2004-10-25 19:04:30 -06:00
+++ edited/drivers/net/tulip/de2104x.c 2005-02-07 09:51:57 -07:00
@@ -1958,8 +1958,6 @@
dev->tx_timeout = de_tx_timeout;
dev->watchdog_timeo = TX_TIMEOUT;
- dev->irq = pdev->irq;
-
de = dev->priv;
de->de21040 = ent->driver_data == 0 ? 1 : 0;
de->pdev = pdev;
@@ -1994,6 +1992,8 @@
pdev->irq, pci_name(pdev));
goto err_out_res;
}
+
+ dev->irq = pdev->irq;
/* obtain and check validity of PCI I/O address */
pciaddr = pci_resource_start(pdev, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-11 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-07 18:49 [PATCH] de214x.c uses uninitialized pci_dev->irq Bjorn Helgaas
2005-02-11 22:09 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox