From: Fruhwirth Clemens <clemens@endorphin.org>
To: James Morris <jmorris@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, michal@logix.cz,
"David S. Miller" <davem@davemloft.net>,
"Adam J. Richter" <adam@yggdrasil.com>
Subject: Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm
Date: Wed, 09 Feb 2005 00:53:56 +0100 [thread overview]
Message-ID: <1107906836.15942.131.camel@ghanima> (raw)
In-Reply-To: <Xine.LNX.4.44.0502081821180.1670-100000@thoron.boston.redhat.com>
On Tue, 2005-02-08 at 18:30 -0500, James Morris wrote:
> On Tue, 8 Feb 2005, Fruhwirth Clemens wrote:
>
> > I shot out the last patch too quickly. Having reviewed the mapping one
> > more time I noticed, that there as the possibility of "off-by-one"
> > unmapping, and instead of doing doubtful guesses, if that's the case, I
> > added a base pointer to scatter_walk, which is the pointer returned by
> > kmap. Exactly this pointer will be unmapped again, so the vaddr
> > comparison in crypto_kunmap doesn't have to do any masking.
>
> You can't call kmap() in softirq context (why was it even trying?):
Why not? What's the alternative, then?
--
Fruhwirth Clemens <clemens@endorphin.org> http://clemens.endorphin.org
next prev parent reply other threads:[~2005-02-08 23:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 11:56 [PATCH 01/04] Adding cipher mode context information to crypto_tfm Fruhwirth Clemens
2005-01-24 12:31 ` James Morris
2005-01-24 22:31 ` Andrew Morton
2005-01-24 23:12 ` Fruhwirth Clemens
2005-01-25 15:52 ` James Morris
2005-01-25 17:38 ` Fruhwirth Clemens
2005-01-25 18:56 ` James Morris
2005-01-29 18:13 ` Fruhwirth Clemens
2005-01-29 18:23 ` Andrew Morton
2005-01-30 18:07 ` Fruhwirth Clemens
2005-02-02 22:46 ` James Morris
2005-02-02 23:28 ` Fruhwirth Clemens
2005-02-02 23:34 ` David S. Miller
2005-02-03 0:21 ` Fruhwirth Clemens
2005-02-03 0:29 ` David S. Miller
2005-02-03 0:40 ` Michal Ludvig
2005-02-03 8:55 ` Fruhwirth Clemens
2005-02-02 23:46 ` James Morris
2005-02-02 23:47 ` James Morris
2005-02-03 11:47 ` Fruhwirth Clemens
2005-02-08 14:14 ` James Morris
2005-02-05 9:23 ` Fruhwirth Clemens
2005-02-08 14:48 ` James Morris
2005-02-08 16:08 ` Fruhwirth Clemens
2005-02-08 16:39 ` Fruhwirth Clemens
2005-02-08 23:30 ` James Morris
2005-02-08 23:53 ` Fruhwirth Clemens [this message]
2005-02-09 0:09 ` James Morris
2005-02-09 9:14 ` Fruhwirth Clemens
2005-02-10 0:30 ` James Morris
2005-02-10 1:02 ` Fruhwirth Clemens
2005-02-10 1:19 ` Andrew Morton
2005-02-10 1:37 ` Christophe Saout
2005-02-10 9:48 ` Fruhwirth Clemens
2005-02-10 10:33 ` Andrew Morton
2005-02-10 11:17 ` Fruhwirth Clemens
2005-02-10 17:02 ` James Morris
2005-02-10 17:29 ` Fruhwirth Clemens
2005-02-10 17:54 ` James Morris
2005-02-14 13:20 ` Fruhwirth Clemens
2005-02-14 15:56 ` David S. Miller
2005-02-14 17:06 ` Fruhwirth Clemens
2005-02-14 17:07 ` David S. Miller
2005-02-14 17:28 ` Fruhwirth Clemens
2005-02-14 18:16 ` Andrew Morton
2005-02-22 19:16 ` Fruhwirth Clemens
2005-02-12 0:24 ` Matt Mackall
2005-02-10 20:30 ` David S. Miller
2005-02-10 1:42 ` James Morris
2005-02-10 9:50 ` Fruhwirth Clemens
2005-02-02 23:00 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107906836.15942.131.camel@ghanima \
--to=clemens@endorphin.org \
--cc=adam@yggdrasil.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@logix.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox