Re: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC

[MyungJoo Ham <myungjoo.ham@samsung.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1250 bytes --]

Sender : Andrew Morton<akpm@linux-foundation.org>
Date : 2011-11-29 08:48 (GMT+09:00)
Title : Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC
> 
> On Thu, 24 Nov 2011 18:12:18 +0900
> Donggeun Kim wrote:
> >
> > ...
> >
> > +static irqreturn_t max8997_muic_irq_handler(int irq, void *data)
> > +{
> > + struct max8997_muic_info *info = data;
> > +
> > + dev_dbg(info->dev, "irq:%d ", irq);
> > + info->irq = irq;
> > +
> > + schedule_work(&info->irq_work);
> > +
> > + return IRQ_HANDLED;
> > +}
> 
> The code does schedule_work() but I see no flush_work().  Is it
> possible for the work to still be pending after device shutdown, or
> even after rmmod?
> 

Yes, it is possible that the work is still pending or running and use data that are freed by max8997_muic_remove().

To be safe with the last-minute interrupt handling, we may need to add flush_work or cancel_work_sync at max8997_muic_remove().

> 

 MyungJoo Ham (ÇÔ¸íÁÖ)

Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥