Re: [PATCH 00/15] staging: exfat: Clean up return codes

Valdis Klētnieks
2019-10-24T16:45:16Z

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Thu, 24 Oct 2019 09:23:24 -0700, Joe Perches said:

> All well and good, but does converting the error code from
> positive to negative have any impact on any of the code
> paths that use these return values?
>
> if (error > 0)
> vs
> if (error < 0)

I was keeping an eye open for that, and didn't see any.

An interesting case is the FFS_EOF patch, which fixes an actual bug. If you did
a read for length 0, it would return FFS_EOF (==15) - which would be
interpreted as the number of bytes returned by read().

[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]