public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] quiet non-x86 option ROM warnings
Date: Wed, 16 Feb 2005 12:03:37 +1100	[thread overview]
Message-ID: <1108515817.13375.63.camel@gaston> (raw)
In-Reply-To: <200502151557.06049.jbarnes@sgi.com>

On Tue, 2005-02-15 at 15:57 -0800, Jesse Barnes wrote:
> Both the r128 and radeon drivers complain if they don't find an x86 option ROM 
> on the device they're talking to.  This would be fine, except that the 
> message is incorrect--not all option ROMs are required to be x86 based.  This 
> small patch just removes the messages altogether, causing the drivers to 
> *silently* fall back to the non-x86 option ROM behavior (it works fine and 
> there's no cause for alarm).

What about printing "No PCI ROM detected" ? I like having that info when
getting user reports, but I agree that a less worrying message would
be good.

Ben.



  parent reply	other threads:[~2005-02-16  1:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15 23:57 [PATCH] quiet non-x86 option ROM warnings Jesse Barnes
2005-02-16  0:36 ` Jon Smirl
2005-02-16  0:45   ` Jesse Barnes
2005-02-16  1:00     ` Benjamin Herrenschmidt
2005-02-16  1:00     ` Benjamin Herrenschmidt
2005-02-16  1:08       ` Jon Smirl
2005-02-16  1:57         ` Jesse Barnes
2005-02-16  4:00         ` Benjamin Herrenschmidt
2005-02-16  1:03 ` Benjamin Herrenschmidt [this message]
2005-02-16 23:54   ` Jesse Barnes
2005-02-17  0:48     ` Benjamin Herrenschmidt
2005-02-17 16:33       ` Jon Smirl
2005-02-17 17:29         ` Jesse Barnes
2005-02-17 17:32           ` Jon Smirl
2005-02-17 17:41             ` Jesse Barnes
2005-02-17 17:45             ` Jesse Barnes
2005-02-17 17:56               ` Jon Smirl
2005-02-17 22:48                 ` Benjamin Herrenschmidt
2005-02-17 22:47               ` Benjamin Herrenschmidt
2005-02-17 22:59                 ` Jon Smirl
2005-02-17 23:00                   ` Jesse Barnes
2005-02-17 23:04                   ` Benjamin Herrenschmidt
2005-02-17 23:20                   ` Andrew Vasquez
2005-02-17 22:45         ` Benjamin Herrenschmidt
2005-02-17 22:56           ` Jon Smirl
2005-02-18 12:09             ` Gabriel Paubert
2005-02-18 16:50               ` Jon Smirl
2005-09-04 13:27 ` Olaf Hering
2005-09-04 14:20   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1108515817.13375.63.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=jbarnes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox