From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Jesse Barnes <jbarnes@sgi.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] quiet non-x86 option ROM warnings
Date: Fri, 18 Feb 2005 10:04:10 +1100 [thread overview]
Message-ID: <1108681450.5666.19.camel@gaston> (raw)
In-Reply-To: <9e47339105021714593115dacf@mail.gmail.com>
On Thu, 2005-02-17 at 17:59 -0500, Jon Smirl wrote:
> On Fri, 18 Feb 2005 09:47:15 +1100, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > We could provide additional helpers, like pci_find_rom_partition(),
> > which takes the architecture code as an argument. It would check the
> > signature, and iterate all "partitions" til it finds the proper
> > architecture (or none).
>
> The spec allows for it but has anyone actually seen a ROM with
> multiple images in it? I haven't but I only work on x86.
Yes, I pretty sure some video cards did that in the past at least, and
maybe some scsi cards. It was a while ago, I don't know if this is still
true, but it's relatively easy to do, let's just hide all of this logic,
along with size & signature checking in a single place, that way, we
don't have to duplicate all that logic in drivers...
Ben.
next prev parent reply other threads:[~2005-02-17 23:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 23:57 [PATCH] quiet non-x86 option ROM warnings Jesse Barnes
2005-02-16 0:36 ` Jon Smirl
2005-02-16 0:45 ` Jesse Barnes
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:00 ` Benjamin Herrenschmidt
2005-02-16 1:08 ` Jon Smirl
2005-02-16 1:57 ` Jesse Barnes
2005-02-16 4:00 ` Benjamin Herrenschmidt
2005-02-16 1:03 ` Benjamin Herrenschmidt
2005-02-16 23:54 ` Jesse Barnes
2005-02-17 0:48 ` Benjamin Herrenschmidt
2005-02-17 16:33 ` Jon Smirl
2005-02-17 17:29 ` Jesse Barnes
2005-02-17 17:32 ` Jon Smirl
2005-02-17 17:41 ` Jesse Barnes
2005-02-17 17:45 ` Jesse Barnes
2005-02-17 17:56 ` Jon Smirl
2005-02-17 22:48 ` Benjamin Herrenschmidt
2005-02-17 22:47 ` Benjamin Herrenschmidt
2005-02-17 22:59 ` Jon Smirl
2005-02-17 23:00 ` Jesse Barnes
2005-02-17 23:04 ` Benjamin Herrenschmidt [this message]
2005-02-17 23:20 ` Andrew Vasquez
2005-02-17 22:45 ` Benjamin Herrenschmidt
2005-02-17 22:56 ` Jon Smirl
2005-02-18 12:09 ` Gabriel Paubert
2005-02-18 16:50 ` Jon Smirl
2005-09-04 13:27 ` Olaf Hering
2005-09-04 14:20 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108681450.5666.19.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=jbarnes@sgi.com \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox