From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: 2.6.11-rc5
Date: Sat, 26 Feb 2005 12:13:09 +1100 [thread overview]
Message-ID: <1109380389.15026.112.camel@gaston> (raw)
In-Reply-To: <20050226004137.GA25539@suse.de>
On Sat, 2005-02-26 at 01:41 +0100, Olaf Hering wrote:
>
> modedb can not be __init because fb_find_mode() may get db == NULL.
> fb_find_mode() is called from modules.
Ahhh, good catch ! I though that was fixed long ago, looks like I was
wrong.
Ben.
> Signed-off-by: Olaf Hering <eolh@suse.de>
>
> diff -purNx tags linux-2.6.11-rc5.orig/drivers/video/modedb.c linux-2.6.11-rc5/drivers/video/modedb.c
> --- linux-2.6.11-rc5.orig/drivers/video/modedb.c 2005-02-24 17:40:24.000000000 +0100
> +++ linux-2.6.11-rc5/drivers/video/modedb.c 2005-02-26 01:37:43.138003474 +0100
> @@ -37,7 +37,7 @@ const char *global_mode_option;
>
> #define DEFAULT_MODEDB_INDEX 0
>
> -static const __init struct fb_videomode modedb[] = {
> +static const struct fb_videomode modedb[] = {
> {
> /* 640x400 @ 70 Hz, 31.5 kHz hsync */
> NULL, 70, 640, 400, 39721, 40, 24, 39, 9, 96, 2,
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2005-02-26 1:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 4:18 2.6.11-rc5 Linus Torvalds
2005-02-24 6:24 ` 2.6.11-rc5 Michael Neuffer
2005-02-24 15:49 ` 2.6.11-rc5 Linus Torvalds
2005-02-24 6:29 ` 2.6.11-rc5 Matt Mackall
2005-02-24 12:49 ` 2.6.11-rc5 Matthias-Christian Ott
2005-02-24 14:25 ` 2.6.11-rc5 Steven Rostedt
2005-02-24 14:57 ` 2.6.11-rc5 M.Baris Demiray
2005-02-24 15:39 ` 2.6.11-rc5 Sergey Vlasov
2005-02-24 15:57 ` 2.6.11-rc5 Steven Rostedt
2005-02-24 15:53 ` 2.6.11-rc5 Gabriel Paubert
2005-02-24 14:50 ` 2.6.11-rc5 Olaf Hering
2005-02-24 17:14 ` 2.6.11-rc5 Olaf Hering
2005-02-24 23:28 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-25 7:08 ` 2.6.11-rc5 Olaf Hering
2005-02-25 7:29 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-25 13:30 ` 2.6.11-rc5 Mws
2005-02-26 0:50 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-03-01 11:36 ` 2.6.11-rc5 Mws
2005-03-01 14:36 ` 2.6.11-rc5 Helge Hafting
2005-03-01 14:39 ` 2.6.11-rc5 Mws
2005-03-01 21:38 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-03-01 22:01 ` 2.6.11-rc5 Mws
2005-02-25 17:29 ` 2.6.11-rc5 Olaf Hering
2005-02-25 17:59 ` [Linux-fbdev-devel] 2.6.11-rc5 James Simmons
2005-02-25 20:24 ` Olaf Hering
2005-02-25 21:21 ` Olaf Hering
2005-02-25 23:30 ` Olaf Hering
2005-02-26 1:01 ` Benjamin Herrenschmidt
2005-02-26 9:52 ` Giuseppe Bilotta
2005-02-26 0:58 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-02-26 0:57 ` Benjamin Herrenschmidt
2005-02-26 0:54 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 0:41 ` 2.6.11-rc5 Olaf Hering
2005-02-26 0:49 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 0:53 ` 2.6.11-rc5 Olaf Hering
2005-02-26 1:04 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 1:08 ` [Linux-fbdev-devel] 2.6.11-rc5 Buttchereit, Axel (XL)
2005-02-26 1:17 ` Benjamin Herrenschmidt
2005-02-26 1:13 ` Benjamin Herrenschmidt [this message]
2005-02-26 7:41 ` Antonino A. Daplas
2005-02-27 8:07 ` 2.6.11-rc5 Geert Uytterhoeven
2005-02-24 15:57 ` 2.6.11-rc5 (compile stats) John Cherry
2005-02-24 16:30 ` 2.6.11-rc5 Brian Gerst
2005-02-24 17:00 ` 2.6.11-rc5 Linus Torvalds
2005-02-25 21:47 ` 2.6.11-rc5 Bill Davidsen
2005-02-25 21:50 ` 2.6.11-rc5 Lee Revell
2005-02-26 5:03 ` 2.6.11-rc5 Bill Davidsen
2005-02-27 20:32 ` 2.6.11-rc5, rivafb i2c oops, bogus error handling Olaf Hering
2005-02-28 14:41 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 12:02 ` Olaf Hering
2005-03-01 20:58 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2005-02-24 6:23 2.6.11-rc5 Voluspa
[not found] <3BjgD-5iu-7@gated-at.bofh.it>
2005-02-25 16:28 ` 2.6.11-rc5 Vincent C Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109380389.15026.112.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox