From: colbuse@ensisun.imag.fr
To: linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] drivers/chat/vt.c: remove unnecessary code
Date: Mon, 28 Feb 2005 16:16:15 +0100 [thread overview]
Message-ID: <1109603775.422335bfa0e62@webmail.imag.fr> (raw)
>On Mon, Feb 28, 2005 at 01:55:28PM +0100, colbuse@xxxxxxxxxxxxxxx wrote:
>
>> Avoid changing the state of the console two times in some cases.
>
>A bad change for several reasons.
>
>(i) more object code is generated
>(ii) the code is slower
>(iii) you change something
>
>Straight line code is cheap, jumps are expensive.
>Replacing an assignment by a jump is not an improvement.
I didn't thought to that point...
You're right, this patch was a bad idea :(.
Sorry about this error...
--
Emmanuel Colbus
Club GNU/Linux
ENSIMAG - Departement telecoms
-------------------------------------------------
envoyé via Webmail/IMAG !
next reply other threads:[~2005-02-28 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 15:16 colbuse [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-28 12:55 [patch 2/2] drivers/chat/vt.c: remove unnecessary code colbuse
2005-02-28 14:45 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109603775.422335bfa0e62@webmail.imag.fr \
--to=colbuse@ensisun.imag.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox