Re: [PATCH] orinoco rfmon

David Gibson
2005-02-28T01:03:20Z

[-- Attachment #1: Type: text/plain, Size: 2570 bytes --]

On Sun, Feb 27, 2005 at 04:45:46PM -0800, Eric Gaumer wrote:
> David Gibson wrote:
> >
> >This looks like the ancient version of the monitor patch - which
> >includes importing a lot of needless junk from the linux-wlan-ng
> >tree. A cleaned up version of monitor has been merged in the orinoco
> >CVS tree for ages now, but unfortunately that's long overdue for a
> >merge with mainline. I'm trying to get that merge done - I just don't
> >have much time or energy for the orinoco driver these days. One stack
> >of patches which gets part of the way went to Jeff Garzik last week.
> >We'll see how we go.
> >
> >In the meantime go to http://savannah.nongnu.org/projects/orinoco for
> >access to the driver CVS. You probably want to get the "for_linus"
> >branch of CVS if you're planning to work with 2.6.
> >
>
> Thanks David, the CVS code works great with the small excpetion of the
> following change to
> get it to build.
>
> diff -Nru orinoco-cvs/orinoco_cs.c orinoco-build/orinoco_cs.c
> +++ orinoco-build/orinoco_cs.c 2005-02-27 15:00:07.698368136 -0800
> @@ -428,7 +428,7 @@
> SET_MODULE_OWNER(dev);
> card->node.major = card->node.minor = 0;
>
> - SET_NETDEV_DEV(dev, &handle_to_dev(handle));
> + dev->name[0] = '\0';
> /* Tell the stack we exist */
> if (register_netdev(dev) != 0) {
> printk(KERN_ERR PFX "register_netdev() failed\n");
>
>
> What's the deal with the broken firmware for monitor mode?
>
> * v0.15rc1 -> v0.15rc2 - 28 Jul 2004 - Pavel Roskin & David Gibson
> * o orinoco_pci saves PCI registers on suspend (Simon Huggins).
> * o Monitor mode disabled on Agere 8.xx firmware - it's broken.
>
> I have 8.4 but things seem fine (used this card in monitor mode for over a
> year without
> problems).
>
> I just disabled the check for broken firmware and things seem fine (better
> than the original
> patch I posted). The iwlist command now works. Could the buggy firmware be
> generalized a bit
> too much? Perhaps only certain versions > 8 are buggy?

Possibly, but I don't really have the means to find out in more
detail. The trouble is that when it falls over, it falls over very
badly, which is why we disable this rather than just letting the user
risk it. Pavel knows more of the details on this one.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist. NOT _the_ _other_ _way_
| _around_!
http://www.ozlabs.org/people/dgibson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]