From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Cc: alexn@dsv.su.se
Subject: [PATCH] PCI: fix hotplug double free
Date: Fri, 4 Mar 2005 12:53:58 -0800 [thread overview]
Message-ID: <11099696383203@kroah.com> (raw)
In-Reply-To: <11099696383198@kroah.com>
ChangeSet 1.1998.11.26, 2005/02/25 15:48:12-08:00, alexn@dsv.su.se
[PATCH] PCI: fix hotplug double free
With the brackets missed out func could be freed twice.
Found by Coverity tool
Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/hotplug/pciehp_ctrl.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -Nru a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
--- a/drivers/pci/hotplug/pciehp_ctrl.c 2005-03-04 12:41:13 -08:00
+++ b/drivers/pci/hotplug/pciehp_ctrl.c 2005-03-04 12:41:13 -08:00
@@ -1354,10 +1354,11 @@
dbg("PCI Bridge Hot-Remove s:b:d:f(%02x:%02x:%02x:%02x)\n",
ctrl->seg, func->bus, func->device, func->function);
bridge_slot_remove(func);
- } else
+ } else {
dbg("PCI Function Hot-Remove s:b:d:f(%02x:%02x:%02x:%02x)\n",
ctrl->seg, func->bus, func->device, func->function);
slot_remove(func);
+ }
func = pciehp_slot_find(ctrl->slot_bus, device, 0);
}
next prev parent reply other threads:[~2005-03-04 21:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11099696382684@kroah.com>
2005-03-04 20:53 ` PCI: remove pci_find_device usage from pci sysfs code Greg KH
2005-03-04 20:53 ` [PATCH] PCI: Apple PCI IDs update Greg KH
2005-03-04 20:53 ` [PATCH] PCI: tone down pci=routeirq message Greg KH
2005-03-04 20:53 ` Greg KH [this message]
2005-03-04 20:53 ` [PATCH] PCI: One more Asus SMBus quirk Greg KH
2005-03-08 22:18 ` Bill Davidsen
2005-03-08 22:21 ` Jean Delvare
2005-03-08 22:21 ` Bill Davidsen
2005-03-08 23:37 ` Greg KH
2005-03-09 16:06 ` Bill Davidsen
2005-03-09 16:37 ` Greg KH
2005-03-10 11:54 ` Bill Davidsen
2005-03-10 16:36 ` Greg KH
2005-03-20 14:53 ` PCI: remove pci_find_device usage from pci sysfs code Rolf Eike Beer
2005-03-21 18:40 ` Greg KH
2005-03-24 21:06 ` Rolf Eike Beer
2005-03-28 23:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11099696383203@kroah.com \
--to=greg@kroah.com \
--cc=alexn@dsv.su.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox