From: James Bottomley <James.Bottomley@SteelEye.com>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [patch] add scsi changer driver
Date: Sun, 06 Mar 2005 19:55:25 +0200 [thread overview]
Message-ID: <1110131725.9206.25.camel@mulgrave> (raw)
In-Reply-To: <20050216143936.GA23892@bytesex>
Looking through this, the only things I really noticed that need work
are:
ch_do_scsi(): It looks like this has an effective reimplementation of
scsi_wait_req. We're trying to deprecate the usage of scsi_do_req so we
can make it private eventually. What's the reason you can't use
scsi_wait_req?
ch_ioctl() (and the compat): since this is a new driver, can't this all
be done via sysfs? That way, the user would be able to manipulate it
from the command line, and we'd no longer need any of the 32->64 compat
glue.
James
next prev parent reply other threads:[~2005-03-06 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 16:42 [patch] add scsi changer driver Gerd Knorr
2005-02-15 17:54 ` Christoph Hellwig
2005-02-16 14:39 ` Gerd Knorr
2005-03-06 17:55 ` James Bottomley [this message]
2005-03-07 8:21 ` Gerd Knorr
2005-03-07 8:42 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110131725.9206.25.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox