Re: [3/many] acrypto: acrypto.h

Evgeniy Polyakov
2005-03-08T00:13:22Z

On Mon, 07 Mar 2005 15:50:28 -0800
"Randy.Dunlap" <rddunlap@osdl.org> wrote:

> Evgeniy Polyakov wrote:
> > --- /tmp/empty/acrypto.h 1970-01-01 03:00:00.000000000 +0300
> > +++ ./acrypto/acrypto.h 2005-03-07 20:35:36.000000000 +0300
> > @@ -0,0 +1,245 @@
> > +/*
> > + * acrypto.h
> > + *
> > + * Copyright (c) 2004 Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> > + *
> > + */
> > +
> > +#ifdef __KERNEL__
> > +
> > +#define SESSION_COMPLETED (1<<15)
> > +#define SESSION_FINISHED (1<<14)
> > +#define SESSION_STARTED (1<<13)
> > +#define SESSION_PROCESSED (1<<12)
> > +#define SESSION_BINDED (1<<11)
> Just a thought: SESSION_BOUND ??
>
> > +#define SESSION_BROKEN (1<<10)
> > +#define SESSION_FROM_CACHE (1<<9)
> > +
> > +#define DEVICE_BROKEN (1<<0)
> > +
> > +#define device_broken(dev) (dev->flags & DEVICE_BROKEN)
> > +#define broke_device(dev) do {dev->flags |= DEVICE_BROKEN;} while(0)
> break_device(dev)

Mdaa, my spelling is quite broken in some places...

> > +int match_initializer(struct crypto_device *, struct crypto_session_initializer *);
> > +int __match_initializer(struct crypto_capability *, struct crypto_session_initializer *);
> > +
> > +#endif /* __KERNEL__ */
> > +#endif /* __ACRYPTO_H */
>
> Several of these could use some namespace_idents on them (SESSION_xyz,
> DEVICE_xyz, device_xyz, match_xyz)...

Hmm, I think I'm not following...

> --
> ~Randy

Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt