Re: [8/many] acrypto: crypto_dev.c

Evgeniy Polyakov
2005-03-07T23:57:28Z

On Mon, 07 Mar 2005 15:37:30 -0800
"Randy.Dunlap" <rddunlap@osdl.org> wrote:

> Evgeniy Polyakov wrote:
> > --- /tmp/empty/crypto_dev.c 1970-01-01 03:00:00.000000000 +0300
> > +++ ./acrypto/crypto_dev.c 2005-03-07 20:35:36.000000000 +0300
> > @@ -0,0 +1,421 @@
> > +/*
> > + * crypto_dev.c
> > + *
> > + * Copyright (c) 2004 Evgeniy Polyakov <johnpol@2ka.mipt.ru>
>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/moduleparam.h>
> > +#include <linux/types.h>
> > +#include <linux/list.h>
> > +#include <linux/slab.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/spinlock.h>
> > +#include <linux/device.h>
>
> In alpha order as much as possible, please.

As far as I remember, some must be first, like kernel.h and module.h,
but I will try to follow alphabet order.

> > +#include "acrypto.h"
> > +
> > +static LIST_HEAD(cdev_list);
> > +static spinlock_t cdev_lock = SPIN_LOCK_UNLOCKED;
>
> DEFINE_SPINLOCK(cdev_lock);

Yep, I suspect some other files also need that.

Will put it into TODO queue.

> --
> ~Randy

Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt