Re: [PATCH] add a clear_pages function to clear pages of higher order

[Dave Hansen <haveblue@us.ibm.com>]

On Thu, 2005-03-10 at 12:35 -0800, Christoph Lameter wrote:
> +#ifdef __HAVE_ARCH_CLEAR_PAGES
> +	if (!PageHighMem(page)) {
> +		clear_pages(page_address(page), order);
> +		return;
> +	}
> +#endif
> +
>  	for(i = 0; i < (1 << order); i++)
>  		clear_highpage(page + i);
>  }
...
> --- linux-2.6.11.orig/include/asm-ia64/page.h	2005-03-01 23:37:48.000000000 -0800
> +++ linux-2.6.11/include/asm-ia64/page.h	2005-03-10 10:57:10.000000000 -0800
> @@ -56,8 +56,10 @@
>  # ifdef __KERNEL__
>  #  define STRICT_MM_TYPECHECKS
> 
> -extern void clear_page (void *page);
> +extern void clear_pages (void *page, int order);
>  extern void copy_page (void *to, void *from);
> +#define clear_page(__page) clear_pages(__page, 0)
> +#define __HAVE_ARCH_CLEAR_PAGES

Although this is a simple instance, could this please be done in a
Kconfig file?  If that #define happens inside of other #ifdefs, it can
be quite hard to decipher the special .config incantation to get it set.
On the other hand, if the dependencies are spelled out in a Kconfig
entry...

BTW, I tried applying this to 2.6.11-bk6, and it rejected:
...
patching file include/asm-i386/page.h
Hunk #2 FAILED at 28.
1 out of 2 hunks FAILED -- saving rejects to file
include/asm-i386/page.h.rej
...

There were some more rejects as well.  Were there some other patches
applied first?

-- Dave