From: "J.A. Magallon" <jamagallon@able.es>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] make gconfig build again
Date: Wed, 16 Mar 2005 22:57:46 +0000 [thread overview]
Message-ID: <1111013866l.23273l.0l@werewolf.able.es> (raw)
In-Reply-To: <20050316132600.3f6e4df2.akpm@osdl.org> (from akpm@osdl.org on Wed Mar 16 22:26:00 2005)
On 03.16, Andrew Morton wrote:
> "J.A. Magallon" <jamagallon@able.es> wrote:
> >
> > On 03.16, Andrew Morton wrote:
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11-mm4/
> > >
> > ...
> > >
> > > +revert-gconfig-changes.patch
> > >
> > > Back out a recent change which broke gconfig.
> > >
> >
> > What was broken ?
>
> hm. I emailed you twice, and had a feeling that things weren't getting
> through.
>
> The patch caused those little pixmap buttons across the top of the main
> window to vanish when using gtk+-1.2.10-28.1. See
> http://www.zip.com.au/~akpm/linux/patches/stuff/x.jpg.
>
> I now note that scripts/kconfig/gconf.c doesn't compile at all with the
> above backout patch. Drat.
>
This is enough to make it compile:
diff -ruN linux-2.6.11-mm4/scripts/kconfig/gconf.c linux-2.6.11-mm4-gconf/scripts/kconfig/gconf.c
--- linux-2.6.11-mm4/scripts/kconfig/gconf.c 2005-03-16 23:45:56.000000000 +0100
+++ linux-2.6.11-mm4-gconf/scripts/kconfig/gconf.c 2005-03-16 23:48:25.000000000 +0100
@@ -11,6 +11,7 @@
#endif
#include "lkc.h"
+#include "images.c"
#include <glade/glade.h>
#include <gtk/gtk.h>
@@ -1171,42 +1172,6 @@
}
-/* Conf management */
-
-static const char *xpm_menu[] = {
-"12 12 2 1",
-" c white",
-". c black",
-" ",
-" ",
-" . ",
-" .. ",
-" ... ",
-" .... ",
-" ..... ",
-" .... ",
-" ... ",
-" .. ",
-" . ",
-" "};
-
-static const char *xpm_void[] = {
-"12 12 2 1",
-" c white",
-". c black",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" ",
-" "};
-
/* Fill a row of strings */
static gchar **fill_row(struct menu *menu)
{
--
J.A. Magallon <jamagallon()able!es> \ Software is like sex:
werewolf!able!es \ It's better when it's free
Mandrakelinux release 10.2 (Cooker) for i586
Linux 2.6.11-jam5 (gcc 3.4.3 (Mandrakelinux 10.2 3.4.3-6mdk)) #1
next prev parent reply other threads:[~2005-03-16 23:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 12:06 2.6.11-mm4 Andrew Morton
2005-03-16 14:22 ` 2.6.11-mm4 Benoit Boissinot
2005-03-16 17:31 ` 2.6.11-mm4 Adrian Bunk
2005-03-16 14:33 ` 2.6.11-mm4 Brice Goglin
2005-03-16 15:07 ` 2.6.11-mm4 J.A. Magallon
2005-03-16 18:22 ` 2.6.11-mm4 Sam Ravnborg
2005-03-16 18:33 ` 2.6.11-mm4 Sam Ravnborg
2005-03-16 21:26 ` 2.6.11-mm4 Andrew Morton
2005-03-16 22:39 ` 2.6.11-mm4 J.A. Magallon
2005-03-16 23:03 ` 2.6.11-mm4 Andrew Morton
2005-03-17 21:47 ` 2.6.11-mm4 Sam Ravnborg
2005-03-16 22:57 ` J.A. Magallon [this message]
2005-03-16 23:09 ` [PATCH] make gconfig build again Andrew Morton
2005-03-16 16:15 ` 2.6.11-mm4 maximilian attems
2005-03-16 22:50 ` 2.6.11-mm4 Sean Neakums
2005-03-16 23:06 ` 2.6.11-mm4 Andrew Morton
2005-03-16 23:22 ` 2.6.11-mm4 Sean Neakums
2005-03-17 8:19 ` 2.6.11-mm4 Paul Mundt
2005-03-17 8:42 ` 2.6.11-mm4 Borislav Petkov
2005-03-17 9:18 ` 2.6.11-mm4 Andrew Morton
2005-03-17 9:42 ` 2.6.11-mm4 Borislav Petkov
2005-03-17 11:07 ` 2.6.11-mm4 Borislav Petkov
2005-03-17 13:41 ` 2.6.11-mm4 Barry K. Nathan
2005-03-17 14:07 ` 2.6.11-mm4 Borislav Petkov
2005-03-23 9:42 ` 2.6.11-mm4 and 2.6.12-rc1-mm1 Borislav Petkov
2005-03-23 10:17 ` Andrew Morton
2005-03-24 7:09 ` Borislav Petkov
2005-03-19 13:39 ` 2.6.11-mm4: drivers/scsi/arcmsr/arcmsr.c: enormous stack usage Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111013866l.23273l.0l@werewolf.able.es \
--to=jamagallon@able.es \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox