* [PATCH] new hp diva console port
@ 2005-03-18 16:30 Alex Williamson
2005-03-19 16:06 ` Russell King
0 siblings, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2005-03-18 16:30 UTC (permalink / raw)
To: rmk+serial; +Cc: linux-kernel
The patch below adds IDs and setup for a new PCI Diva console port.
This device provides a single UART described by PCI Bar 1. ID already
submitted to pciids.sf.net. Please apply. Thanks,
Alex
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
===== drivers/pci/pci.ids 1.74 vs edited =====
--- 1.74/drivers/pci/pci.ids 2005-03-15 08:33:16 -07:00
+++ edited/drivers/pci/pci.ids 2005-03-17 10:54:25 -07:00
@@ -1812,6 +1812,7 @@
103c 1226 Keystone SP2
103c 1227 Powerbar SP2
103c 1282 Everest SP2
+ 103c 1301 Diva RMP3
1054 PCI Local Bus Adapter
1064 79C970 PCnet Ethernet Controller
108b Visualize FXe
===== drivers/serial/8250_pci.c 1.51 vs edited =====
--- 1.51/drivers/serial/8250_pci.c 2005-03-08 15:08:47 -07:00
+++ edited/drivers/serial/8250_pci.c 2005-03-17 10:54:26 -07:00
@@ -2185,6 +2185,9 @@
* HP Diva card
*/
{ PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA,
+ PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA_RMP3, 0, 0,
+ pbn_b1_1_115200 },
+ { PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA,
PCI_ANY_ID, PCI_ANY_ID, 0, 0,
pbn_b0_5_115200 },
{ PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA_AUX,
===== include/linux/pci_ids.h 1.208 vs edited =====
--- 1.208/include/linux/pci_ids.h 2005-03-15 08:27:33 -07:00
+++ edited/include/linux/pci_ids.h 2005-03-17 10:56:15 -07:00
@@ -709,6 +709,7 @@
#define PCI_DEVICE_ID_HP_SX1000_IOC 0x127c
#define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
#define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
+#define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
#define PCI_DEVICE_ID_HP_CISSA 0x3220
#define PCI_DEVICE_ID_HP_CISSB 0x3230
#define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] new hp diva console port
@ 2005-10-22 0:30 Chen, Justin
2005-10-24 18:32 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Chen, Justin @ 2005-10-22 0:30 UTC (permalink / raw)
To: rmk+serial; +Cc: linux-kernel, linux-serial
This patch adds the new ID 0x132a and configure the new PCI Diva console
port. This device support only 1 single console UART. Please apply.
Thanks,
Justin Chen
--- 8250_pci.c.orig 2005-10-18 15:56:50.148489501 -0700
+++ 8250_pci.c 2005-10-18 15:55:25.624076474 -0700
@@ -178,6 +178,7 @@ static int __devinit pci_hp_diva_init(st
rc = 4;
break;
case PCI_DEVICE_ID_HP_DIVA_POWERBAR:
+ case PCI_DEVICE_ID_HP_DIVA_HURRICANE:
rc = 1;
break;
}
--- pci_ids.h.orig 2005-10-18 16:02:56.864305321 -0700
+++ pci_ids.h 2005-10-18 16:03:54.002976496 -0700
@@ -710,6 +710,7 @@
#define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
#define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
#define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
+#define PCI_DEVICE_ID_HP_DIVA_HURRICANE 0x132a
#define PCI_DEVICE_ID_HP_CISSA 0x3220
#define PCI_DEVICE_ID_HP_CISSB 0x3230
#define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] new hp diva console port
2005-10-22 0:30 Chen, Justin
@ 2005-10-24 18:32 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2005-10-24 18:32 UTC (permalink / raw)
To: Chen, Justin; +Cc: rmk+serial, linux-kernel, linux-serial
On Friday 21 October 2005 6:30 pm, Chen, Justin wrote:
> This patch adds the new ID 0x132a and configure the new PCI Diva console
> port. This device support only 1 single console UART. Please apply.
It'll be easier to apply this if you follow the guidelines in
Documentation/SubmittingPatches. For example, the patch should
apply with "patch -p1", add "Signed-off-by:", etc.
> --- 8250_pci.c.orig 2005-10-18 15:56:50.148489501 -0700
> +++ 8250_pci.c 2005-10-18 15:55:25.624076474 -0700
> @@ -178,6 +178,7 @@ static int __devinit pci_hp_diva_init(st
> rc = 4;
> break;
> case PCI_DEVICE_ID_HP_DIVA_POWERBAR:
> + case PCI_DEVICE_ID_HP_DIVA_HURRICANE:
> rc = 1;
> break;
> }
> --- pci_ids.h.orig 2005-10-18 16:02:56.864305321 -0700
> +++ pci_ids.h 2005-10-18 16:03:54.002976496 -0700
> @@ -710,6 +710,7 @@
> #define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
> #define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
> #define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
> +#define PCI_DEVICE_ID_HP_DIVA_HURRICANE 0x132a
> #define PCI_DEVICE_ID_HP_CISSA 0x3220
> #define PCI_DEVICE_ID_HP_CISSB 0x3230
> #define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] new hp diva console port
@ 2005-10-24 21:38 Chen, Justin
2005-10-24 22:35 ` Russell King
0 siblings, 1 reply; 6+ messages in thread
From: Chen, Justin @ 2005-10-24 21:38 UTC (permalink / raw)
To: Helgaas, Bjorn; +Cc: rmk+serial, linux-kernel, linux-serial
On Monday, October 24, 2005 11:33 AM, Helgaas, Bjorn wrote:
>It'll be easier to apply this if you follow the guidelines in
>Documentation/SubmittingPatches. For example, the patch
>should apply with "patch -p1", add "Signed-off-by:", etc.
Okay, here is the adjusted format and the signature -
This patch adds the new ID 0x132a and configure the new PCI Diva console
port. This device support only 1 single console UART. Please apply.
Thanks,
Signed-off-by: Justin Chen <justin.chen@hp.com>
------------------------------------------------------------------------
-------------------------------------------------------
diff -uprN -X dontdiff linux-vanilla/drivers/serial/8250_pci.c
ia-26126/drivers/serial/8250_pci.c
--- linux-vanilla/drivers/serial/8250_pci.c 2005-10-24
12:32:01.817851490 -0700
+++ ia-26126/drivers/serial/8250_pci.c 2005-10-24 12:24:13.628404100
-0700
@@ -177,6 +177,7 @@ static int __devinit pci_hp_diva_init(st
rc = 4;
break;
case PCI_DEVICE_ID_HP_DIVA_POWERBAR:
+ case PCI_DEVICE_ID_HP_DIVA_HURRICANE:
rc = 1;
break;
}
diff -uprN -X dontdiff linux-vanilla/include/linux/pci_ids.h
ia-26126/include/linux/pci_ids.h
--- linux-vanilla/include/linux/pci_ids.h 2005-10-24
12:31:49.661601638 -0700
+++ ia-26126/include/linux/pci_ids.h 2005-10-24 12:23:31.366685868
-0700
@@ -711,6 +711,7 @@
#define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
#define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
#define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
+#define PCI_DEVICE_ID_HP_DIVA_HURRICANE 0x132a
#define PCI_DEVICE_ID_HP_CISSA 0x3220
#define PCI_DEVICE_ID_HP_CISSB 0x3230
#define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
------------------------------------------------------------------------
--------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] new hp diva console port
2005-10-24 21:38 Chen, Justin
@ 2005-10-24 22:35 ` Russell King
0 siblings, 0 replies; 6+ messages in thread
From: Russell King @ 2005-10-24 22:35 UTC (permalink / raw)
To: Chen, Justin; +Cc: Helgaas, Bjorn, linux-kernel, linux-serial
On Mon, Oct 24, 2005 at 02:38:02PM -0700, Chen, Justin wrote:
> On Monday, October 24, 2005 11:33 AM, Helgaas, Bjorn wrote:
> >It'll be easier to apply this if you follow the guidelines in
> >Documentation/SubmittingPatches. For example, the patch
> >should apply with "patch -p1", add "Signed-off-by:", etc.
>
> Okay, here is the adjusted format and the signature -
>
> This patch adds the new ID 0x132a and configure the new PCI Diva console
> port. This device support only 1 single console UART. Please apply.
> Thanks,
>
> Signed-off-by: Justin Chen <justin.chen@hp.com>
I've actually already committed this, via Andrew Morton. Note,
however, that your mailer has wrapped the patch, so maybe it's
better for you to attach patches (as text/plain) to your emails?
> ------------------------------------------------------------------------
> -------------------------------------------------------
> diff -uprN -X dontdiff linux-vanilla/drivers/serial/8250_pci.c
> ia-26126/drivers/serial/8250_pci.c
> --- linux-vanilla/drivers/serial/8250_pci.c 2005-10-24
> 12:32:01.817851490 -0700
> +++ ia-26126/drivers/serial/8250_pci.c 2005-10-24 12:24:13.628404100
> -0700
> @@ -177,6 +177,7 @@ static int __devinit pci_hp_diva_init(st
> rc = 4;
> break;
> case PCI_DEVICE_ID_HP_DIVA_POWERBAR:
> + case PCI_DEVICE_ID_HP_DIVA_HURRICANE:
> rc = 1;
> break;
> }
> diff -uprN -X dontdiff linux-vanilla/include/linux/pci_ids.h
> ia-26126/include/linux/pci_ids.h
> --- linux-vanilla/include/linux/pci_ids.h 2005-10-24
> 12:31:49.661601638 -0700
> +++ ia-26126/include/linux/pci_ids.h 2005-10-24 12:23:31.366685868
> -0700
> @@ -711,6 +711,7 @@
> #define PCI_DEVICE_ID_HP_DIVA_EVEREST 0x1282
> #define PCI_DEVICE_ID_HP_DIVA_AUX 0x1290
> #define PCI_DEVICE_ID_HP_DIVA_RMP3 0x1301
> +#define PCI_DEVICE_ID_HP_DIVA_HURRICANE 0x132a
> #define PCI_DEVICE_ID_HP_CISSA 0x3220
> #define PCI_DEVICE_ID_HP_CISSB 0x3230
> #define PCI_DEVICE_ID_HP_ZX2_IOC 0x4031
> ------------------------------------------------------------------------
> --------------------------------------------------------------
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-10-24 22:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-18 16:30 [PATCH] new hp diva console port Alex Williamson
2005-03-19 16:06 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2005-10-22 0:30 Chen, Justin
2005-10-24 18:32 ` Bjorn Helgaas
2005-10-24 21:38 Chen, Justin
2005-10-24 22:35 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox