Re: [PATCH 1/5] freepgt: free_pgtables use vma list

Nick Piggin
2005-03-23T00:19:44Z

David S. Miller wrote:
> On Wed, 23 Mar 2005 10:32:10 +1100
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>
>>I think David's on the right track - I think there's something a
>>bit wrong at the top. In my reply to Andrew in this thread I
>>posted a patch which may at least get things working...
>
>
> We have to do the "if (ceiling)" check in every spot where
> we mask it in some way, and if it falls to zero from non-zero
> due to the masking, we skip.
>
> That gives me a mostly working kernel.
>

I see. Tricky.

> Bad news is that while lat_proc's fork and exec tests improve
> dramatically, shell performance is way down on sparc64.
> I'll post before and after numbers in a bit. Note, this is
> just with Hugh's base patch plus bug fixes.
>

That's interesting. The only "extra" stuff Hugh's should be
doing is the vma traversal.

The single walk patch seems to fit in quite well with Hugh's
updated patchset. I haven't quite worked out how to best do
hugepages, but it is easily possible. But I won't dust that
off again until Hugh's is nicely tested and working.