Re: [PATCH 1/5] freepgt: free_pgtables use vma list

David S. Miller
2005-03-22T23:57:49Z

On Tue, 22 Mar 2005 15:53:08 -0800
"Luck, Tony" <tony.luck@intel.com> wrote:

> But I'm still confused by all the math on addr/end at each
> level. Rounding up/down at each level should presumably be
> based on the size of objects at the next level. So the pgd
> code should round using PUD_MASK, pud should use PMD_MASK etc.
> Perhaps I missed some updates, but the version of the patch
> that I have (and the simulator) is using PMD_MASK in the
> pgd_free_range() function ... which is surely wrong.

PMD_MASK decides the smallest page table chunk, so we mask
it at the top level.

Look at the next level down in the call chain, the masking
maskes more sense there.