Re: NFS client latencies

Trond Myklebust
2005-03-31T12:34:59Z

to den 31.03.2005 Klokka 06:58 (-0500) skreiv Trond Myklebust:
>
> @@ -563,11 +566,14 @@ static int
> nfs_scan_commit(struct inode *inode, struct list_head *dst, unsigned long idx_start, unsigned int npages)
> {
> struct nfs_inode *nfsi = NFS_I(inode);
> - int res;
> - res = nfs_scan_list(&nfsi->commit, dst, idx_start, npages);
> - nfsi->ncommit -= res;
> - if ((nfsi->ncommit == 0) != list_empty(&nfsi->commit))
> - printk(KERN_ERR "NFS: desynchronized value of nfs_i.ncommit.\n");
> + int res;
^^^^^^^ Should be "int res = 0;"
> +
> + if (nfsi->ncommit != 0) {
> + res = nfs_scan_list(&nfsi->commit, dst, idx_start, npages);
> + nfsi->ncommit -= res;
> + if ((nfsi->ncommit == 0) != list_empty(&nfsi->commit))
> + printk(KERN_ERR "NFS: desynchronized value of nfs_i.ncommit.\n");
> + }
> return res;
> }
> #endif

Cheers,
Trond
--
Trond Myklebust <trond.myklebust@fys.uio.no>