Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

Rolf Eike Beer
2005-04-02T12:14:52Z

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Greg KH wrote:
> ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, eike-hotplug@sf-tec.de
>
> [PATCH] PCI Hotplug: remove code duplication in
> drivers/pci/hotplug/ibmphp_pci.c
>
> This patch removes some code duplication where if and else have the
> same code at the beginning and the end of the branch.

Greg, as you correctly pointed out this patch if broken. It could never reach
the if branch and always uses the else branch. Please drop this one and
review the patch I sent on March 21th to pcihp-discuss for inclusion. It
removes much more duplication and handles this case correctly. Sorry, it
looks like I forgot to CC you. I'll bounce this mail to you.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]