PCI Hotplug: enforce the rule that a hotplug slot needs a release function.

Greg KH
2005-04-01T23:50:07Z

ChangeSet 1.2181.16.17, 2005/03/21 22:55:26-08:00, gregkh@suse.de

PCI Hotplug: enforce the rule that a hotplug slot needs a release function.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/pci/hotplug/pci_hotplug_core.c | 5 +++++
1 files changed, 5 insertions(+)

diff -Nru a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
--- a/drivers/pci/hotplug/pci_hotplug_core.c 2005-04-01 15:34:15 -08:00
+++ b/drivers/pci/hotplug/pci_hotplug_core.c 2005-04-01 15:34:15 -08:00
@@ -567,6 +567,11 @@
return -ENODEV;
if ((slot->info == NULL) || (slot->ops == NULL))
return -EINVAL;
+ if (slot->release == NULL) {
+ dbg("Why are you trying to register a hotplug slot"
+ "without a proper release function?\n");
+ return -EINVAL;
+ }

kobject_set_name(&slot->kobj, "%s", slot->name);
kobj_set_kset_s(slot, pci_hotplug_slots_subsys);