[PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro

Greg KH
2005-04-02T00:51:42Z

ChangeSet 1.2181.16.16, 2005/03/17 14:50:04-08:00, akpm@osdl.org

[PATCH] arch/i386/pci/i386.c: Use new for_each_pci_dev macro

From: Domen Puncer <domen@coderock.org>

As requested by Christoph Hellwig I created a new macro called
for_each_pci_dev. It is a wrapper for this common use of
pci_get/find_device:

(while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL))

This macro will return the pci_dev *for all pci devices. Here is the first
patch I used to test this macro with. Compiled and booted on my T23.
There will be 53 more patches using this new macro.

Signed-off-by: Hanna Linder <hannal@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

arch/i386/pci/i386.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -Nru a/arch/i386/pci/i386.c b/arch/i386/pci/i386.c
--- a/arch/i386/pci/i386.c 2005-04-01 15:34:37 -08:00
+++ b/arch/i386/pci/i386.c 2005-04-01 15:34:37 -08:00
@@ -124,7 +124,7 @@
u16 command;
struct resource *r, *pr;

- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
+ for_each_pci_dev(dev) {
pci_read_config_word(dev, PCI_COMMAND, &command);
for(idx = 0; idx < 6; idx++) {
r = &dev->resource[idx];
@@ -168,7 +168,7 @@
int idx;
struct resource *r;

- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
+ for_each_pci_dev(dev) {
int class = dev->class >> 8;

/* Don't touch classless devices and host bridges */