Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

Greg KH
2005-04-08T00:12:21Z

On Sat, Apr 02, 2005 at 02:20:11PM +0200, Rolf Eike Beer wrote:
> Greg KH wrote:
> > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, eike-hotplug@sf-tec.de
> >
> > [PATCH] PCI Hotplug: remove code duplication in
> > drivers/pci/hotplug/ibmphp_pci.c
> >
> > This patch removes some code duplication where if and else have the
> > same code at the beginning and the end of the branch.
>
> Greg, as you correctly pointed out this patch if broken. It could never reach
> the if branch and always uses the else branch. Please drop this one and
> review the patch I sent on March 21th to pcihp-discuss for inclusion. It
> removes much more duplication and handles this case correctly. Sorry, it
> looks like I forgot to CC you. I'll bounce this mail to you.

Hm, care to send me a patch that backs the old one out? Or just one
that fixes it properly, I can't really revert the old patch, now that
I'm not using bitkeeper :)

thanks,

greg k-h