From: Alexander Nyberg <alexn@telia.com>
To: Brian Gerst <bgerst@didntduck.org>, torvalds@osdl.org
Cc: ak@suse.de, linux-kernel@vger.kernel.org, akpm@osdl.org,
nicolas@boichat.ch
Subject: Re: x86_64: Bug in new out of line put_user()
Date: Fri, 22 Apr 2005 10:22:14 +0200 [thread overview]
Message-ID: <1114158134.917.8.camel@localhost.localdomain> (raw)
In-Reply-To: <42684603.5050500@didntduck.org>
Brian, thanks for seeing this. (me goes hiding...)
The labels after the last put_user patch were misplaced so
exceptions on the real mov instructions would not be handled.
Index: test/arch/x86_64/lib/putuser.S
===================================================================
--- test.orig/arch/x86_64/lib/putuser.S 2005-04-22 10:04:25.000000000 +0200
+++ test/arch/x86_64/lib/putuser.S 2005-04-22 10:06:29.000000000 +0200
@@ -49,8 +49,8 @@
jc 20f
cmpq threadinfo_addr_limit(%r8),%rcx
jae 20f
-2: decq %rcx
- movw %dx,(%rcx)
+ decq %rcx
+2: movw %dx,(%rcx)
xorl %eax,%eax
ret
20: decq %rcx
@@ -64,8 +64,8 @@
jc 30f
cmpq threadinfo_addr_limit(%r8),%rcx
jae 30f
-3: subq $3,%rcx
- movl %edx,(%rcx)
+ subq $3,%rcx
+3: movl %edx,(%rcx)
xorl %eax,%eax
ret
30: subq $3,%rcx
@@ -79,8 +79,8 @@
jc 40f
cmpq threadinfo_addr_limit(%r8),%rcx
jae 40f
-4: subq $7,%rcx
- movq %rdx,(%rcx)
+ subq $7,%rcx
+4: movq %rdx,(%rcx)
xorl %eax,%eax
ret
40: subq $7,%rcx
prev parent reply other threads:[~2005-04-22 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 23:10 x86_64: Bug in new out of line put_user() Alexander Nyberg
2005-04-21 11:10 ` Andi Kleen
2005-04-21 13:05 ` Nicolas Boichat
2005-04-21 23:55 ` Nicolas Boichat
2005-04-22 0:32 ` Brian Gerst
2005-04-22 8:22 ` Alexander Nyberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114158134.917.8.camel@localhost.localdomain \
--to=alexn@telia.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas@boichat.ch \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox