Re: [PATCH] PCI: Add pci shutdown ability

Grant Grundler
2005-04-26T17:40:43Z

On Tue, Apr 26, 2005 at 01:14:38PM -0400, Alan Stern wrote:
> On Tue, 26 Apr 2005, Grant Grundler wrote:
>
> > Agreed - but this is a different problem than "shutting down IRQs".
> > My point was arch specific code knows how to mask all IRQs.
> > irq_disable() is expected to work regardless of what state the
> > driver is in. On kexec "reboot", kernel drivers can unmask IRQs
> > as they normally would during initialization. No?
>
> One has to be careful when talking about enabling/disable IRQs, because
> there are (at least) two choke points: one on the device and one on the
> computer's interrupt controller. Masking IRQs takes place on the
> controller, but I was talking about stopping interrupt requests at their
> source on the device. It's the only way to avoid problems when IRQ lines
> are shared.

Yes, got it. I wouldn't object if someone said kexec can not
support shared IRQs unless both drivers sharing the IRQ implement
PCI "suspend" hook (and disable IRQ on the respective devices).
We really don't have many options to fix Shared IRQ problems.

thanks,
grant