Re: [linux-usb-devel] Re: [PATCH] PCI: Add pci shutdown ability

Adam Belay
2005-04-26T06:38:07Z

On Tue, Apr 26, 2005 at 01:39:20PM +1000, Benjamin Herrenschmidt wrote:
>
> > Yes.
> >
> > I believe it should just do suspend(PMSG_SUSPEND) before system
> > shutdown. If you think distintion between shutdown and suspend is
> > important (I am not 100% convinced it is), we can just add flag
> > saying "this is system shutdown".
> >
> > Actually this patch should be in the queue somewhere... We had it in
> > suse trees for a long time, and IMO it can solve problem easily.
>
> I think we probably want a distinct state for shutdown ...
>
> Ben.

Yes, it's possible we do. I'm not sure what every platform requires. The
question is should we make this change to pm_message_t in the short term?
"->shutdown", even though incorrect, seems to fill this role.

Greg, have you seen shutdown methods doing anything special other than
standard "->suspend" stuff?

Thanks,
Adam