From: Lee Revell <rlrevell@joe-job.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: David Addison <addy@quadrics.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Andrea Arcangeli <andrea@suse.de>,
David Addison <david.addison@quadrics.com>
Subject: Re: [PATCH][RFC] Linux VM hooks for advanced RDMA NICs
Date: Tue, 26 Apr 2005 13:28:31 -0400 [thread overview]
Message-ID: <1114536511.5410.14.camel@mindpipe> (raw)
In-Reply-To: <Pine.LNX.4.62.0504261918210.2071@dragon.hyggekrogen.localhost>
On Tue, 2005-04-26 at 19:20 +0200, Jesper Juhl wrote:
> I don't know what you do, but when I'm grep'ing the tree for some function
> I'm often looking for its return type, having that on the same line as the
> function name lets me grep for the function name and the grep output will
> contain the return type and function name nicely on the same line.
>
I do a lot of looking at large hunks of code I'm not familiar with and
trying to figure out how it works. It's quite handy to grep for
foo_func to see all usages, then ^foo_func to see the function. I guess
my preferred style favors people trying to grok code for the first time,
while the kernel style favors those who know it inside out.
Anyway, the coding style guidelines also state clearly that these points
are not up for debate on LKML so I'll stop now...
Lee
next prev parent reply other threads:[~2005-04-26 17:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 15:49 [PATCH][RFC] Linux VM hooks for advanced RDMA NICs David Addison
2005-04-26 16:57 ` Jesper Juhl
2005-04-26 17:13 ` Lee Revell
2005-04-26 17:20 ` Jesper Juhl
2005-04-26 17:28 ` Lee Revell [this message]
2005-04-26 17:38 ` Jesper Juhl
2005-04-26 20:14 ` John W. Linville
2005-04-26 20:17 ` Lee Revell
2005-04-26 20:09 ` Lars Marowsky-Bree
2005-04-28 11:34 ` Jakob Oestergaard
2005-04-29 8:22 ` Benjamin Herrenschmidt
2005-04-26 17:06 ` Brice Goglin
2005-04-27 9:41 ` David Addison
2005-04-28 8:38 ` Andy Isaacson
2005-04-27 13:43 ` Andi Kleen
2005-04-28 1:42 ` Troy Benjegerdes
2005-04-28 7:21 ` Brice Goglin
2005-04-28 9:21 ` David Addison
2005-04-29 8:19 ` Benjamin Herrenschmidt
2005-04-29 9:25 ` David Addison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114536511.5410.14.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=addy@quadrics.com \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=david.addison@quadrics.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox