From: Keith Owens <kaos@ocs.com.au>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH - gameport_{,un}register_port must be static when inline
Date: Thu, 04 Oct 2001 14:31:29 +1000 [thread overview]
Message-ID: <11147.1002169889@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Thu, 04 Oct 2001 14:19:13 +1000." <15291.58177.900493.276071@notabene.cse.unsw.edu.au>
On Thu, 4 Oct 2001 14:19:13 +1000 (EST),
Neil Brown <neilb@cse.unsw.edu.au> wrote:
>Linus,
> 2.4.11-pre2 wont compile with some combinations of sound card drivers
> if CONFIG_INPUT_GAMEPORT is not defined, as every driver than include
> gameport.h causes "gameport_register_port" to be defined as a symbol
> and there is a conflict.
>
> This patch makes the relevant inline functions "static" to avoid this
> problem.
Please don't. This was fixed in the -ac trees several weeks ago, the
correct fix is to move the input rewrite from -ac to Linus's tree.
That is up to the maintainer, Vojtech Pavlik.
next prev parent reply other threads:[~2001-10-04 4:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-04 4:19 PATCH - gameport_{,un}register_port must be static when inline Neil Brown
2001-10-04 4:31 ` Keith Owens [this message]
2001-10-04 5:04 ` Neil Brown
2001-10-04 5:10 ` Keith Owens
2001-10-04 5:32 ` Neil Brown
2001-10-04 12:50 ` Keith Owens
2001-10-04 5:30 ` Keith Owens
2001-10-04 20:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11147.1002169889@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox