Re: 2.6.11.7 kernel panic on boot on AMD64

Andi Kleen
2005-04-29T14:48:38Z

On Fri, Apr 29, 2005 at 04:41:04PM +0200, Ruben Puettmann wrote:
> On Fri, Apr 29, 2005 at 04:32:15PM +0200, Andi Kleen wrote:
> >
> > Hmm? saved_command_Line should have enough space to add a simple string.
> > It is a 1024bytes. Unless you already have a 1k command line it should
> > be quite ok.
>
> Here it seems that it is 256 bytes :
>
> init/main.c:char saved_command_line[COMMAND_LINE_SIZE];
>
> include/asm-x86_64/setup.h:#define COMMAND_LINE_SIZE 256

Yes, only the early buffer is 1K.

>
>
> > Why do you think it is bogus?
> >
> > > This is bogus appending stuff to the saved_command_line and at the same
> > > time in Rubens case it touches the late_time_init() which breakes havoc.
> >
> > I dont agree with this patch.
> >
>
> The patch workes here fine. After apply the Server boots without any
> problem.

Ok. If you really had such a overlong command line it is ok.

We should probably check this condition better too and error out.

-Andi
>
>
> Ruben
>
> --
> Ruben Puettmann
> ruben@puettmann.net
> http://www.puettmann.net