From: Dmitry Yusupov <dima@neterion.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Olivier Galibert <galibert@pobox.com>,
avi@argo.co.il, linux-kernel@vger.kernel.org
Subject: Re: tcp_sendpage and page allocation lifetime vs. iscsi
Date: Fri, 29 Apr 2005 10:09:02 -0700 [thread overview]
Message-ID: <1114794542.10446.8.camel@beastie> (raw)
In-Reply-To: <20050425150840.5f27f77a.davem@davemloft.net>
On Mon, 2005-04-25 at 15:08 -0700, David S. Miller wrote:
> On Tue, 26 Apr 2005 00:06:03 +0200
> Olivier Galibert <galibert@pobox.com> wrote:
>
> > Do you think possible to extent the sendpage api to add some kind of
> > "don't get the pages, copy them if you need them" flag?
>
> No, not really.
>
> Do you happen to run the scsi->done() function from iscsi
> as soon as the write over the TCP socket completes returns
> success? That is likely what is causing the problem.
Your guess is correct. If this happen Olivier will see corruption sooner
or later. But this should never happen, unless we have a subtle bug in
iscsi_tcp.c which needs to be verified and fixed.
Since SCSI tape device usually causing a lot of sense data, we probably
have a bug around sense data path processing. And this is not related to
TCP API abuse in anyway. I would recommend to continue this discussion
on www.open-iscsi.org mailing list.
Dima
prev parent reply other threads:[~2005-04-29 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-25 17:02 tcp_sendpage and page allocation lifetime vs. iscsi Olivier Galibert
2005-04-25 19:11 ` Avi Kivity
2005-04-25 19:19 ` David S. Miller
2005-04-25 19:43 ` Avi Kivity
2005-04-25 19:37 ` David S. Miller
2005-04-25 22:06 ` Olivier Galibert
2005-04-25 22:08 ` David S. Miller
2005-04-25 22:31 ` Olivier Galibert
2005-04-29 17:09 ` Dmitry Yusupov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114794542.10446.8.camel@beastie \
--to=dima@neterion.com \
--cc=avi@argo.co.il \
--cc=davem@davemloft.net \
--cc=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox