From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: "Rogério Brito" <rbrito@ime.usp.br>,
"Andrew Morton" <akpm@osdl.org>,
"Linux Kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.12-rc3-mm2
Date: Mon, 02 May 2005 10:37:27 +1000 [thread overview]
Message-ID: <1114994247.7111.347.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.62.0505012224350.2488@dragon.hyggekrogen.localhost>
> I recently posted this patch in another thread, give it a try :
>
> --- linux-2.6.12-rc3-mm2-orig/fs/proc/task_mmu.c 2005-05-01 04:04:25.000000000 +0200
> +++ linux-2.6.12-rc3-mm2/fs/proc/task_mmu.c 2005-05-01 17:49:14.000000000 +0200
> @@ -2,6 +2,7 @@
> #include <linux/hugetlb.h>
> #include <linux/mount.h>
> #include <linux/seq_file.h>
> +#include <linux/highmem.h>
>
> #include <asm/elf.h>
> #include <asm/uaccess.h>
> @@ -204,7 +205,7 @@ static void smaps_pte_range(pmd_t *pmd,
> }
> }
> } while (address < end);
> - pte_unmap(pte);
> + pte_unmap((void *)pte);
> }
>
> static void smaps_pmd_range(pud_t *pud,
This is unrelated, and shouldn't be necessary. I don't lile patches that
defeat typechecking. Of pte isn't a pte_t *, then something is wrong.
Ben.
next prev parent reply other threads:[~2005-05-02 0:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 20:11 2.6.12-rc3-mm2 Rogério Brito
2005-05-01 20:26 ` 2.6.12-rc3-mm2 Jesper Juhl
2005-05-01 21:35 ` 2.6.12-rc3-mm2 Rogério Brito
2005-05-02 0:37 ` Benjamin Herrenschmidt [this message]
2005-05-02 8:34 ` 2.6.12-rc3-mm2 Rogério Brito
-- strict thread matches above, loose matches on Subject: below --
2005-05-01 10:10 2.6.12-rc3-mm2 Mikael Pettersson
2005-05-01 10:27 ` 2.6.12-rc3-mm2 Benoit Boissinot
2005-05-01 12:51 ` 2.6.12-rc3-mm2 Benoit Boissinot
2005-04-30 23:43 2.6.12-rc3-mm2 Andrew Morton
2005-05-01 0:27 ` 2.6.12-rc3-mm2 Benoit Boissinot
2005-05-01 0:37 ` 2.6.12-rc3-mm2 Andrew Morton
[not found] ` <40f323d00504301753140a7ef4@mail.gmail.com>
2005-05-01 1:12 ` 2.6.12-rc3-mm2 Benoit Boissinot
2005-05-02 5:07 ` 2.6.12-rc3-mm2 James Cloos
2005-05-02 5:26 ` 2.6.12-rc3-mm2 Andrew Morton
2005-04-30 21:34 ` 2.6.12-rc3-mm2 Diego Calleja
2005-05-03 16:08 ` 2.6.12-rc3-mm2 Bill Davidsen
2005-05-03 13:37 ` 2.6.12-rc3-mm2 Barry K. Nathan
2005-05-04 15:12 ` 2.6.12-rc3-mm2 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114994247.7111.347.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rbrito@ime.usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox