public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>,
	alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: [PATCH] ppc32: Small build fix for alsa powermac
Date: Mon, 02 May 2005 11:40:30 +1000	[thread overview]
Message-ID: <1114998030.7112.364.camel@gaston> (raw)

Hi !

My newer iMac mini driver doesn't build with verbose debug enabled. This
fixes it, and removes an erroneous error printk (since it's normal on
some machine to not find some gpios on the "first try").

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Index: linux-work/sound/ppc/toonie.c
===================================================================
--- linux-work.orig/sound/ppc/toonie.c	2005-05-02 10:51:00.000000000 +1000
+++ linux-work/sound/ppc/toonie.c	2005-05-02 11:38:22.000000000 +1000
@@ -279,8 +279,7 @@
 	if (! base) {
 		base = (u32 *)get_property(np, "reg", NULL);
 		if (!base) {
-			DBG("(E) cannot find address for device %s !\n", device);
-			snd_printd("cannot find address for device %s\n", device);
+			DBG("(E) cannot find address for device %s !\n", name);
 			return -ENODEV;
 		}
 		addr = *base;



             reply	other threads:[~2005-05-02  1:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-02  1:40 Benjamin Herrenschmidt [this message]
2005-05-12 13:07 ` [Alsa-devel] [PATCH] ppc32: Small build fix for alsa powermac Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1114998030.7112.364.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox