I think the general opinion of posting patches as attachments has changed over the last few years. Mailers have been getting a lot better at handling them, even quoting non-message-body plain/text attachments in replies. Plus, a plain/text attachment message saved to a file can go into 'patch' the same way that an inline one can. Signed-off-by: Dave Hansen --- memhotplug-dave/Documentation/SubmittingPatches | 20 ++++++++++++++------ 1 files changed, 14 insertions(+), 6 deletions(-) diff -L Documentation/Submitting -puN /dev/null /dev/null diff -puN Documentation/SubmittingPatches~submitting-patches Documentation/SubmittingPatches --- memhotplug/Documentation/SubmittingPatches~submitting-patches 2005-05-04 08:07:25.000000000 -0700 +++ memhotplug-dave/Documentation/SubmittingPatches 2005-05-04 10:22:43.000000000 -0700 @@ -181,25 +181,33 @@ patches. Trivial patches must qualify fo -6) No MIME, no links, no compression, no attachments. Just plain text. +6) No links, no compressed attachments. Just plain text. Linus and other kernel developers need to be able to read and comment on the changes you are submitting. It is important for a kernel developer to be able to "quote" your changes, using standard e-mail tools, so that they may comment on specific portions of your code. -For this reason, all patches should be submitting e-mail "inline". +For this reason, the preferred way of submitting patches in e-mail is +"inline", in the same part of the message with everything else. WARNING: Be wary of your editor's word-wrap corrupting your patch, if you choose to cut-n-paste your patch. -Do not attach the patch as a MIME attachment, compressed or not. +Many maintainers will now accept patches submitted to them as +text/plain attachments. Many mailers quote these attachements in the +same way that they do for inline patches. But, some maintainers still +prefer inlines and they are certainly the safest bet. In any case, +never attach more than one patch to a single e-mail. + Many popular e-mail applications will not always transmit a MIME attachment as plain text, making it impossible to comment on your -code. A MIME attachment also takes Linus a bit more time to process, -decreasing the likelihood of your MIME-attached change being accepted. +code. If you must use an attachment, verify that it has no +Content-Type-Encoding. A MIME attachment also takes Linus a bit more +time to process, decreasing the likelihood of your MIME-attached +change being accepted. Exception: If your mailer is mangling patches then someone may ask -you to re-send them using MIME. +you to re-send them compressed or using other MIME encodings. _