Re: [RFC][PATCH] update SubmittingPatches to clarify attachment policy

[Alexander Nyberg <alexn@dsv.su.se>]

ons 2005-05-04 klockan 11:14 -0700 skrev Dave Hansen:
> On Wed, 2005-05-04 at 10:55 -0700, Chris Wright wrote:
> > I agree that things are better.  But, ironically, this patch is a case
> > in point.  It's attached as text/x-patch and makes replying to and
> > commenting on patch inline more laborious.
> 
> Well, crap.
> 
> I've sent an awful lot of patches that way, and never had a negative
> reply from a maintainer or a patch commenter.
> 
> As an aside: is there a proper way to do patch text/plain attachments
> from Evolution?  Maybe we need a quick tutorial on what the best way to
> send patches is with several popular mailers.
> 

In evolution I just do new mail => insert => text file and change the
mail to preformat instead of normal formatting. I'm sure there are
settings somewhere to make this default but I don't send enough patches
(yet) to bother, the output works anyway (old patch shown below):

Index: linux-2.6/arch/x86_64/kernel/head64.c
===================================================================
--- linux-2.6.orig/arch/x86_64/kernel/head64.c	2005-04-26 11:41:43.000000000 +0200
+++ linux-2.6/arch/x86_64/kernel/head64.c	2005-04-29 11:57:46.000000000 +0200
@@ -93,9 +93,6 @@
 #ifdef CONFIG_SMP
 	cpu_set(0, cpu_online_map);
 #endif
-	/* default console: */
-	if (!strstr(saved_command_line, "console="))
-		strcat(saved_command_line, " console=tty0"); 
 	s = strstr(saved_command_line, "earlyprintk=");
 	if (s != NULL)
 		setup_early_printk(s);