From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: [PATCH] Fix PCI mmap on ppc and ppc64
Date: Tue, 10 May 2005 23:57:49 +1000 [thread overview]
Message-ID: <1115733469.6157.60.camel@gaston> (raw)
In-Reply-To: <je8y2nqkwk.fsf@sykes.suse.de>
On Tue, 2005-05-10 at 15:18 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > @@ -351,9 +351,12 @@
> > *offset += hose->pci_mem_offset;
> > res_bit = IORESOURCE_MEM;
> > } else {
> > - io_offset = (unsigned long)hose->io_base_virt;
> > + io_offset = (unsigned long)hose->io_base_virt - pci_io_base;
> > + printk("offset: %lx, io_base_virt: %p, pci_io_base: %lx, io_offset: %
> > lx\n",
> > + *offset, hose->io_base_virt, pci_io_base, io_offset);
> > *offset += io_offset;
> > res_bit = IORESOURCE_IO;
> > + printk(" -> offset: %lx\n", *offset);
>
> I don't think you want those debugging printks be left here.
Good point, looks like I got really sloppy on this patch. I'll send a
fix tomorrow unless andrew beats me at it as this isn't yet in any
released -mm
Ben.
prev parent reply other threads:[~2005-05-10 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 4:53 [PATCH] Fix PCI mmap on ppc and ppc64 Benjamin Herrenschmidt
2005-05-10 13:18 ` Andreas Schwab
2005-05-10 13:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115733469.6157.60.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox