From: Marcel Holtmann <marcel@holtmann.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
bluez-devel@lists.sf.net, Maxim Krasnyansky <maxk@qualcomm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bluetooth: kill redundant NULL checks and casts before kfree
Date: Wed, 11 May 2005 12:55:47 +0200 [thread overview]
Message-ID: <1115808947.11503.34.camel@pegasus> (raw)
In-Reply-To: <Pine.LNX.4.62.0505102147190.2386@dragon.hyggekrogen.localhost>
Hi Jesper,
> > > There's no need to check for NULL before calling kfree() on a pointer, and
> > > since kfree() takes a void* argument there's no need to cast pointers to
> > > other types before passing them to kfree().
> >
> > > + kfree(hdev->driver_data)
> >
> > This won't compile.
> >
> Ouch. You are right.
> I usually compile test patches, but I have to admit I didn't this time.
> Sorry about that. Fixed patch below.
the hci_vhci.c change is not needed, because I have a pending update for
that driver that already fixes this. The other two hunks are in my tree
now.
Regards
Marcel
prev parent reply other threads:[~2005-05-11 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 19:05 [PATCH] bluetooth: kill redundant NULL checks and casts before kfree Jesper Juhl
2005-05-10 19:28 ` Alexey Dobriyan
2005-05-10 19:49 ` Jesper Juhl
2005-05-11 10:55 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115808947.11503.34.camel@pegasus \
--to=marcel@holtmann.org \
--cc=adobriyan@gmail.com \
--cc=bluez-devel@lists.sf.net \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox