Re: [PATCH] Driver Core: remove driver model detach_state

Kay Sievers
2005-05-18T10:13:29Z

On Tue, 2005-05-17 at 15:12 -0700, Greg KH wrote:
> [PATCH] Driver Core: remove driver model detach_state
>
> The driver model has a "detach_state" mechanism that:
>
> - Has never been used by any in-kernel drive;
> - Is superfluous, since driver remove() methods can do the same thing;
> - Became buggy when the suspend() parameter changed semantics and type;
> - Could self-deadlock when called from certain suspend contexts;
> - Is effectively wasted documentation, object code, and headspace.
>
> This removes that "detach_state" mechanism; net code shrink, as well
> as a per-device saving in the driver model and sysfs.

Huh, we need to fix a lot of userspace programs now. libsysfs depends on
finding that file, udev waits for this to recognize sysfs population. I
will go fix this where I know this is used, but be prepared for stupid
failures... :)

Thanks,
Kay