public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "K.R. Foley" <kr@cybsft.com>
Cc: dino@in.ibm.com, Andrew Morton <akpm@osdl.org>,
	gregoire.favre@gmail.com,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: What breaks aic7xxx in post 2.6.12-rc2 ?
Date: Wed, 18 May 2005 23:23:50 -0500	[thread overview]
Message-ID: <1116476630.5867.2.camel@mulgrave> (raw)
In-Reply-To: <428C030E.8030102@cybsft.com>

On Wed, 2005-05-18 at 22:07 -0500, K.R. Foley wrote: 
> This also solves my problem that I reported in this thread
> http://marc.theaimsgroup.com/?l=linux-scsi&m=111422854418964&w=2

OK, I think the patch below is the extract of this.  Could you see if it
works by simply patching vanilla 2.6.12-rc4 with no other SCSI patches
(if it does, I'll push it for 2.6.12 final).

James

--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -2300,6 +2300,30 @@ ahc_linux_alloc_target(struct ahc_softc 
 	targ->target = target;
 	targ->ahc = ahc;
 	ahc->platform_data->targets[target_offset] = targ;
+
+	/* FIXME: This code is just for a bug workaround in 2.6.12
+	 * The correct fix will be in 2.6.13 */
+	{
+		struct ahc_devinfo devinfo;
+		struct ahc_initiator_tinfo *tinfo;
+		struct ahc_tmode_tstate *tstate;
+		char my_channel = channel + 'A';
+		unsigned int our_id = ahc->our_id;
+		
+		if (channel)
+			our_id = ahc->our_id_b;
+
+		tinfo = ahc_fetch_transinfo(ahc, my_channel, ahc->our_id,
+					    targ->target, &tstate);
+		ahc_compile_devinfo(&devinfo, our_id, targ->target,
+				    CAM_LUN_WILDCARD, my_channel,
+				    ROLE_INITIATOR);
+		ahc_set_syncrate(ahc, &devinfo, NULL, 0, 0, 0,
+				 AHC_TRANS_GOAL, /*paused*/FALSE);
+		ahc_set_width(ahc, &devinfo, MSG_EXT_WDTR_BUS_8_BIT,
+			      AHC_TRANS_GOAL, /*paused*/FALSE);
+	}
+
 	return (targ);
 }
 



  reply	other threads:[~2005-05-19  4:25 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-16  8:58 What breaks aic7xxx in post 2.6.12-rc2 ? Grégoire Favre
2005-05-16 15:03 ` Jesper Juhl
2005-05-16 15:12   ` What breaks aic7xxx in post 2.6.12-rc2 ? (on amd64 ?) Grégoire Favre
2005-05-16 15:31     ` Jesper Juhl
2005-05-17  7:13 ` What breaks aic7xxx in post 2.6.12-rc2 ? Dinakar Guniguntala
2005-05-17  7:29   ` Andrew Morton
2005-05-17  8:34     ` Dinakar Guniguntala
2005-05-17 14:34     ` James Bottomley
2005-05-17 15:57       ` Grégoire Favre
2005-05-17 16:38         ` James Bottomley
2005-05-17 16:52           ` Grégoire Favre
2005-05-17 18:16             ` James Bottomley
2005-05-17 17:08       ` Dinakar Guniguntala
2005-05-17 18:34         ` James Bottomley
2005-05-17 19:26           ` Grégoire Favre
2005-05-17 19:50             ` James Bottomley
2005-05-17 19:56               ` Grégoire Favre
2005-05-17 21:06                 ` James Bottomley
2005-05-17 22:09                   ` Grégoire Favre
2005-05-17 22:14                     ` James Bottomley
2005-05-21 23:22                   ` Grégoire Favre
2005-05-22 13:54                     ` James Bottomley
2005-05-24 15:39                       ` Grégoire Favre
2005-05-26 13:19                         ` James Bottomley
2005-05-26 14:35                           ` Grégoire Favre
2005-05-26 14:46                             ` James Bottomley
2005-05-26 17:35                               ` Grégoire Favre
2005-05-30 14:38                                 ` James Bottomley
2005-05-30 14:51                                   ` Michael Tokarev
2005-05-30 14:59                                     ` James Bottomley
2005-05-30 15:09                                   ` Grégoire Favre
2005-05-30 15:34                                     ` James Bottomley
2005-05-30 16:01                                       ` Grégoire Favre
2005-05-30 18:17                                         ` James Bottomley
2005-05-30 19:07                                           ` Grégoire Favre
2005-06-06 18:17                                             ` James Bottomley
2005-06-07  8:57                                               ` Grégoire Favre
2005-06-12 15:38                                                 ` James Bottomley
2005-06-13 14:50                                                   ` Grégoire Favre
2005-06-13 14:59                                                     ` James Bottomley
2005-06-13 15:05                                                       ` Christoph Hellwig
2005-06-13 15:17                                                       ` Grégoire Favre
2005-06-13 18:37                                                       ` Gr�goire Favre
2005-06-13 20:50                                                         ` James Bottomley
2005-06-13 21:33                                                           ` Gregoire Favre
2005-06-13 21:46                                                             ` James Bottomley
2005-06-13 21:59                                                               ` Gregoire Favre
2005-06-13 22:04                                                                 ` James Bottomley
2005-06-13 22:25                                                                   ` Gregoire Favre
2005-06-14  2:20                                                                     ` James Bottomley
2005-06-14  9:28                                                                       ` What breaks aic7xxx in post 2.6.12-rc2 ? (fixed in 2.6.12-rc6 with patches) Gregoire Favre
2005-06-13 21:42                                                           ` What breaks aic7xxx in post 2.6.12-rc2 ? Frank van Maarseveen
2005-06-13 22:59                                                             ` James Bottomley
2005-06-14 21:42                                                               ` Frank van Maarseveen
2005-06-15 12:02                                                                 ` Frank van Maarseveen
2005-06-15 14:14                                                                   ` James Bottomley
2005-06-15 20:09                                                                     ` Frank van Maarseveen
2005-06-15 20:15                                                                       ` James Bottomley
2005-06-15 20:15                                                                       ` James Bottomley
2005-06-15 20:49                                                                         ` Frank van Maarseveen
2005-05-18  9:07           ` Dinakar Guniguntala
2005-05-18 14:12             ` James Bottomley
2005-05-18 14:40               ` Dinakar Guniguntala
2005-05-19  3:07           ` K.R. Foley
2005-05-19  4:23             ` James Bottomley [this message]
2005-05-19  9:51               ` Dinakar Guniguntala
2005-05-19 23:56                 ` James Bottomley
2005-05-20  1:05                   ` K.R. Foley
2005-05-20  1:17                     ` James Bottomley
2005-05-20  1:32                       ` K.R. Foley
2005-05-20  1:33                         ` James Bottomley
2005-05-20  1:40                         ` James Bottomley
2005-05-20  1:54                           ` K.R. Foley
2005-05-20  2:30                             ` James Bottomley
2005-05-20  3:06                               ` K.R. Foley
2005-05-20 10:09                   ` Dinakar Guniguntala
2005-05-19 11:27               ` K.R. Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116476630.5867.2.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=dino@in.ibm.com \
    --cc=gregoire.favre@gmail.com \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox