Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path

[Kay Sievers <kay.sievers@vrfy.org>]

On Fri, 2005-05-20 at 10:18 -0700, Tom Rini wrote:
> On Fri, May 20, 2005 at 09:12:55AM +0200, Kay Sievers wrote:
> > On Thu, 2005-05-19 at 09:43 -0700, Tom Rini wrote:
> > > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > > not a defined symbol.  Trivial fix is to EXPORT_SYMBOL hotplug_path.
> > > 
> > > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> > > 
> > > Index: lib/kobject_uevent.c
> > > ===================================================================
> > > --- c7d7a187a2125518e655dfeadffd38156239ffc3/lib/kobject_uevent.c  (mode:100644)
> > > +++ uncommitted/lib/kobject_uevent.c  (mode:100644)
> > > @@ -21,6 +21,7 @@
> > >  #include <linux/string.h>
> > >  #include <linux/kobject_uevent.h>
> > >  #include <linux/kobject.h>
> > > +#include <linux/module.h>
> > >  #include <net/sock.h>
> > >  
> > >  #define BUFFER_SIZE	1024	/* buffer for the hotplug env */
> > > @@ -178,6 +179,7 @@
> > >  
> > >  #ifdef CONFIG_HOTPLUG
> > >  char hotplug_path[HOTPLUG_PATH_LEN] = "/sbin/hotplug";
> > > +EXPORT_SYMBOL(hotplug_path);
> > >  u64 hotplug_seqnum;
> > >  static DEFINE_SPINLOCK(sequence_lock);
> > 
> > Please don't export it again. We're on the way to make it private.
> > Nobody should ever have access to it outside of the driver core. The
> > input layer event stuff is completely broken and we are already working
> > on fixing this to use the driver core instead of calling /sbin/hotplug,
> > which is completely nonsense these days.
> 
> So Greg said he's ACK this since the "make it private" stuff isn't done
> yet.  Will this go in or no?

Well, it doesn't depend on "make it private" it depends on Dimitry, who
wanted to tweak our patch for the input layer. But we wait for weeeks
for that. The SUSE kernel already ships a driver-core input layer
without the /sbin/hotplug stuff.

Kay