From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: [RFC] Changing pci_iounmap to take 'bar' argument
Date: Thu, 26 May 2005 14:07:34 +1000 [thread overview]
Message-ID: <1117080454.9076.25.camel@gaston> (raw)
Hi !
On ppc and ppc64 platforms, pci_iounmap() currently does nothing, which
is bogus (leak of ioremap space for mmio). It needs to iounmap for MMIOs
and do nothign for IO space.
The problem is that wether it's IO or MMIO cannot be easily deduced from
the virtual address. We _could_ change the whole thing on ppc32 to play
tricks with the top address bits, and we could compare the virtual
address with the known regions containing PHBs IO space, but that sounds
to me like working around a bad API in the first place.
What about, instead, just adding the "int bar" argument to pci_iounmap()
like we pass to pci_iomap() so it can access the resource flags ?
If it's ok with you, I'll send a patch doing it later today.
Ben.
next reply other threads:[~2005-05-26 4:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 4:07 Benjamin Herrenschmidt [this message]
2005-05-26 4:25 ` [RFC] Changing pci_iounmap to take 'bar' argument Linus Torvalds
2005-05-26 4:27 ` Benjamin Herrenschmidt
2005-05-26 4:30 ` Benjamin Herrenschmidt
2005-05-26 4:55 ` Benjamin Herrenschmidt
2005-05-26 15:21 ` Linus Torvalds
2005-05-28 20:08 ` Russell King
2005-05-26 22:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117080454.9076.25.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox