From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: ncunningham@cyclades.com
Cc: Pavel Machek <pavel@ucw.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Freezer Patches.
Date: Thu, 02 Jun 2005 11:49:20 +1000 [thread overview]
Message-ID: <1117676961.31082.4.camel@gaston> (raw)
In-Reply-To: <1117676819.10888.109.camel@localhost>
On Thu, 2005-06-02 at 11:46 +1000, Nigel Cunningham wrote:
> Hi.
>
> On Thu, 2005-06-02 at 10:35, Benjamin Herrenschmidt wrote:
> > > I agree that sync() is nice to have, but I'm not going to slow down
> > > fork/exit for it. And besides, sys_sync() just before suspend works
> > > just fine.
> >
> > Yes, that's why I put it in my pre-freeze :)
> >
> > I'll see about making my pre/post freeze stuff (APM emu + sync basically
> > now) generic to avoid the callbacks.
>
> Ummm. Don't do it if kthreads are already frozen. You'll deadlock against kjournald.
Which is why I do it pre-freeze.
With a 2 stage freezing though, it would make sense to first freeze
userland, then sync, then freeze kthreads. That would make the sync
faster (as it won't be "blocked" by pending userland IOs as I experience
regulary here) and more reliable.
Ben.
next prev parent reply other threads:[~2005-06-02 1:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 12:33 Freezer Patches Nigel Cunningham
2005-06-01 13:02 ` Pavel Machek
2005-06-01 22:02 ` Benjamin Herrenschmidt
2005-06-01 22:13 ` Nigel Cunningham
2005-06-01 22:23 ` Benjamin Herrenschmidt
2005-06-01 22:08 ` Nigel Cunningham
2005-06-01 22:31 ` Pavel Machek
2005-06-01 22:45 ` Benjamin Herrenschmidt
2005-06-01 23:02 ` Pavel Machek
2005-06-02 0:35 ` Benjamin Herrenschmidt
2005-06-02 1:46 ` Nigel Cunningham
2005-06-02 1:49 ` Benjamin Herrenschmidt [this message]
2005-06-02 1:45 ` Nigel Cunningham
2005-06-02 1:48 ` Benjamin Herrenschmidt
2005-06-02 7:14 ` Pavel Machek
2005-06-02 7:26 ` Nigel Cunningham
2005-06-02 7:31 ` Pavel Machek
2005-06-02 7:36 ` Benjamin Herrenschmidt
2005-06-02 8:18 ` Nigel Cunningham
2005-06-02 21:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117676961.31082.4.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@cyclades.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox