* [patch]variable overflow after hunderds round of hotplug CPU
@ 2005-06-02 2:56 Shaohua Li
0 siblings, 0 replies; only message in thread
From: Shaohua Li @ 2005-06-02 2:56 UTC (permalink / raw)
To: lkml; +Cc: akpm
Hi,
I'm doing the cpu hotplug stress test and found a variable ('ready') is
overflow after several hundreds rounds of cpu hotplug. Here is a fix.
Signed-off-by: Shaohua Li<shaohua.li@intel.com>
--- a/arch/i386/kernel/head.S 2005-05-26 09:19:44.000000000 +0800
+++ b/arch/i386/kernel/head.S 2005-06-02 10:11:28.447685576 +0800
@@ -299,7 +299,6 @@ is386: movl $2,%ecx # set MP
movl %eax,%cr0
call check_x87
- incb ready
lgdt cpu_gdt_descr
lidt idt_descr
ljmp $(__KERNEL_CS),$1f
@@ -316,8 +315,9 @@ is386: movl $2,%ecx # set MP
lldt %ax
cld # gcc2 wants the direction flag cleared at all times
#ifdef CONFIG_SMP
- movb ready, %cl
- cmpb $1,%cl
+ movb ready, %cl
+ movb $1, ready
+ cmpb $0,%cl
je 1f # the first CPU calls start_kernel
# all other CPUs call initialize_secondary
call initialize_secondary
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-02 2:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-02 2:56 [patch]variable overflow after hunderds round of hotplug CPU Shaohua Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox