From: Marcel Holtmann <marcel@holtmann.org>
To: Abhay Salunke <Abhay_Salunke@dell.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
matt_domsch@dell.com, Greg KH <greg@kroah.com>
Subject: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver
Date: Thu, 02 Jun 2005 23:44:08 +0200 [thread overview]
Message-ID: <1117748648.3656.10.camel@pegasus> (raw)
In-Reply-To: <20050602183648.GA31701@littleblue.us.dell.com>
Hi Abhay,
> This is a resubmit of the patch after incorporating all the inputs from revieweres.
> This has the hotplug firmware interface as suggested by many.
> Currently it does not suport reading back the data; I am workingon it and will add
> that feature as new patch.
please fix the coding style. We use tabs instead of spaces.
Make sure that all functions are static and clean your namespace. Even
if they are static it is still unclean.
It is <linux/firmware.h> and not "linux/firmware.h".
The Kconfig is missing a "select FW_LOADER".
Regards
Marcel
next prev parent reply other threads:[~2005-06-02 21:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 18:36 [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver Abhay Salunke
2005-06-02 21:44 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-20 23:50 [patch 2.6.12-rc3]dell_rbu: " Abhay Salunke
2005-07-09 1:07 Abhay Salunke
2005-06-17 14:55 [patch 2.6.12-rc3] dell_rbu: " Abhay_Salunke
2005-06-17 15:29 ` Greg KH
2005-06-15 17:59 Abhay Salunke
2005-06-16 18:52 ` Greg KH
2005-06-20 0:36 ` Andrew Morton
2005-06-02 23:26 Abhay Salunke
2005-06-02 23:58 ` Marcel Holtmann
2005-06-03 12:32 ` Andreas Henriksson
2005-06-05 21:51 ` Jesper Juhl
2005-05-26 18:43 Abhay_Salunke
2005-05-26 16:37 Abhay_Salunke
2005-05-26 16:56 ` Matt Domsch
2005-05-26 20:37 ` Greg KH
2005-05-26 21:36 ` Marcel Holtmann
2005-05-23 14:52 Abhay_Salunke
2005-05-23 14:58 ` Arjan van de Ven
2005-05-23 14:59 ` Marcel Holtmann
2005-05-23 15:48 ` Greg KH
2005-05-19 12:03 Abhay_Salunke
2005-05-19 14:42 ` Greg KH
2005-05-18 18:13 Abhay Salunke
2005-05-19 3:32 ` Greg KH
2005-05-13 19:00 Abhay Salunke
2005-05-13 21:11 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117748648.3656.10.camel@pegasus \
--to=marcel@holtmann.org \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox