From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Greg KH <gregkh@suse.de>,
tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, roland@topspin.com,
davem@davemloft.net, Michael Chan <mchan@broadcom.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: pci_enable_msi() for everyone?
Date: Sat, 04 Jun 2005 10:01:04 +1000 [thread overview]
Message-ID: <1117843264.31082.204.camel@gaston> (raw)
In-Reply-To: <42A0E4B4.3050309@pobox.com>
> pci_enable(info on what to enable)
>
> so that drivers can specify ahead of time "don't enable PIO, only MMIO",
> "don't enable MMIO, only PIO", "don't use MSI", etc. and add a
> pci_disable() to undo all of that.
>
> The more we add singleton functions like pci_enable_msi(),
> pci_set_master(), etc. the more I wish for a single function that
> handled all those details at one atomic point. There is a lot of
> standard patterns that are hand-coded into every PCI driver's probe
> functions.
Agreed, with the proper arch hook to deal with arch brokenness of
course.
That could be a bitmap. What I'm not 100% confident at this point is
wether we want a bit per BAR or an "IO" bit and an "MMIO" bit. I think
I'd rather go for the first one.
Ben.
next prev parent reply other threads:[~2005-06-04 0:04 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 22:45 pci_enable_msi() for everyone? Greg KH
2005-06-03 23:16 ` Jeff Garzik
2005-06-04 0:01 ` Benjamin Herrenschmidt [this message]
2005-06-04 0:08 ` Jeff Garzik
2005-06-04 0:16 ` Benjamin Herrenschmidt
2005-06-04 0:34 ` Jeff Garzik
2005-06-04 6:51 ` Greg KH
2005-06-03 23:36 ` Roland Dreier
2005-06-06 22:58 ` Greg KH
2005-06-07 0:23 ` Roland Dreier
2005-06-07 5:19 ` Greg KH
2005-06-04 1:31 ` Grant Grundler
2005-06-04 6:48 ` Greg KH
2005-06-04 7:05 ` Grant Grundler
2005-06-04 7:18 ` Greg KH
2005-06-04 7:23 ` Dave Jones
2005-06-04 14:58 ` Roland Dreier
2005-06-06 23:01 ` Greg KH
2005-06-07 0:26 ` Roland Dreier
2005-06-07 5:22 ` Greg KH
2005-06-07 5:46 ` Adam Belay
2005-06-07 17:43 ` Luben Tuikov
2005-06-05 22:00 ` Benjamin Herrenschmidt
2005-06-06 23:00 ` Greg KH
2005-06-06 23:56 ` Benjamin Herrenschmidt
2005-06-05 19:46 ` David S. Miller
2005-06-06 22:55 ` Greg KH
2005-06-06 22:59 ` David S. Miller
2005-06-06 23:09 ` Greg KH
2005-06-06 23:08 ` Jeff Garzik
2005-06-06 23:10 ` David S. Miller
2005-06-06 23:13 ` Greg KH
2005-06-06 23:53 ` Jeff Garzik
2005-06-06 23:56 ` Greg KH
2005-06-06 23:58 ` David S. Miller
2005-06-07 4:24 ` Grant Grundler
2005-06-07 0:18 ` Roland Dreier
2005-06-07 5:21 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-06-07 22:33 Nguyen, Tom L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117843264.31082.204.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mchan@broadcom.com \
--cc=roland@topspin.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox