From: Shaohua Li <shaohua.li@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@osdl.org>, Ashok Raj <ashok.raj@intel.com>,
Zwane Mwaikambo <zwane@linuxpower.ca>, ak <ak@muc.de>
Subject: [PATCH]x86-x86_64 flush cache for CPU hotplug
Date: Fri, 10 Jun 2005 11:30:08 +0800 [thread overview]
Message-ID: <1118374208.7510.6.camel@linux-hp.sh.intel.com> (raw)
Hi,
We should flush cache at CPU hotplug. An error has been observed data is
corrupted after CPU hotplug in CPUs with bigger cache.
I guess IA64 requires similar change, Ashok?
Thanks,
Shaohua
Signed-off-by: Shaohua.li<shaohua.li@intel.com>
---
linux-2.6.12-rc6-mm1-root/arch/i386/kernel/process.c | 1 +
linux-2.6.12-rc6-mm1-root/arch/x86_64/kernel/process.c | 1 +
2 files changed, 2 insertions(+)
diff -puN arch/i386/kernel/process.c~flush_cache_cpuhotplug arch/i386/kernel/process.c
--- linux-2.6.12-rc6-mm1/arch/i386/kernel/process.c~flush_cache_cpuhotplug 2005-06-10 10:56:05.082247160 +0800
+++ linux-2.6.12-rc6-mm1-root/arch/i386/kernel/process.c 2005-06-10 11:05:10.597316264 +0800
@@ -155,6 +155,7 @@ static inline void play_dead(void)
{
/* This must be done before dead CPU ack */
cpu_exit_clear();
+ wbinvd();
mb();
/* Ack it */
__get_cpu_var(cpu_state) = CPU_DEAD;
diff -puN arch/x86_64/kernel/process.c~flush_cache_cpuhotplug arch/x86_64/kernel/process.c
--- linux-2.6.12-rc6-mm1/arch/x86_64/kernel/process.c~flush_cache_cpuhotplug 2005-06-10 10:56:18.270242280 +0800
+++ linux-2.6.12-rc6-mm1-root/arch/x86_64/kernel/process.c 2005-06-10 11:05:23.206399392 +0800
@@ -165,6 +165,7 @@ DECLARE_PER_CPU(int, cpu_state);
static inline void play_dead(void)
{
idle_task_exit();
+ wbinvd();
mb();
/* Ack it */
__get_cpu_var(cpu_state) = CPU_DEAD;
_
next reply other threads:[~2005-06-10 3:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-10 3:30 Shaohua Li [this message]
2005-06-10 16:30 ` [PATCH]x86-x86_64 flush cache for CPU hotplug Ashok Raj
2005-06-10 16:34 ` Ashok Raj
2005-06-10 17:21 ` Andi Kleen
2005-06-13 1:13 ` Shaohua Li
2005-06-10 19:11 ` Zwane Mwaikambo
2005-06-13 1:18 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118374208.7510.6.camel@linux-hp.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox