* [PATCH] radeonfb: don't blow up VGA console on load
@ 2005-06-10 23:45 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2005-06-10 23:45 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Fbdev development list, Linux Kernel list, Linus Torvalds
Hi !
Current radeonfb memset's the framebuffer to 0 when loaded. This removes
occasional artifacts but has the nasty side effect that if you load
radeonfb without framebuffer console, you destroy the VGA text buffer,
font, etc... radeon must not touch the framebuffer content when it
doesn't "own" it.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/drivers/video/aty/radeon_base.c
===================================================================
--- linux-work.orig/drivers/video/aty/radeon_base.c 2005-06-09 16:22:08.000000000 +1000
+++ linux-work/drivers/video/aty/radeon_base.c 2005-06-11 09:42:19.000000000 +1000
@@ -2374,10 +2374,9 @@
} while ( rinfo->fb_base == 0 &&
((rinfo->mapped_vram /=2) >= MIN_MAPPED_VRAM) );
- if (rinfo->fb_base)
- memset_io(rinfo->fb_base, 0, rinfo->mapped_vram);
- else {
- printk (KERN_ERR "radeonfb (%s): cannot map FB\n", pci_name(rinfo->pdev));
+ if (rinfo->fb_base == NULL) {
+ printk (KERN_ERR "radeonfb (%s): cannot map FB\n",
+ pci_name(rinfo->pdev));
ret = -EIO;
goto err_unmap_rom;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-10 23:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-10 23:45 [PATCH] radeonfb: don't blow up VGA console on load Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox