From: Thomas Hood <jdthood@aglu.demon.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, 310865-submitter@bugs.debian.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: [PATCH] apm.c: ignore_normal_resume is set a bit too late
Date: Mon, 13 Jun 2005 15:50:26 +0200 [thread overview]
Message-ID: <1118670626.7066.84.camel@thanatos> (raw)
In-Reply-To: <20050613222003.2895ac2c.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Mon, 2005-06-13 at 22:20 +1000, Stephen Rothwell wrote:
> I am not using APM any more and have no way to test such a change. So,
> can you please do a proper patch with comment and Signed-off-by line and
> send it to Andrew Morton (akpm@osdl.org) (and cc lkml, I guess). When I
> see it, I will Ack it to Andrew.
Summary: apm: Prevent double APM resume on Thinkpad X31
This patch causes the ignore_normal_resume flag to be set slightly
earlier, before there is a chance that the apm driver will receive the
normal resume event from the BIOS. (Addresses Debian bug #310865)
Signed-off-by: Thomas Hood <jdthood@yahoo.co.uk>
--
Thomas Hood <jdthood@aglu.demon.nl>
[-- Attachment #2: apm.c_double_resume_fix_20050613jdth1.patch --]
[-- Type: text/x-patch, Size: 554 bytes --]
--- kernel-source-2.6.11/arch/i386/kernel/apm.c_ORIG 2005-03-02 08:37:47.000000000 +0100
+++ kernel-source-2.6.11/arch/i386/kernel/apm.c 2005-06-13 14:59:51.000000000 +0200
@@ -1220,13 +1220,13 @@ static int suspend(int vetoable)
save_processor_state();
err = set_system_power_state(APM_STATE_SUSPEND);
+ ignore_normal_resume = 1;
restore_processor_state();
write_seqlock_irq(&xtime_lock);
spin_lock(&i8253_lock);
reinit_timer();
set_time();
- ignore_normal_resume = 1;
spin_unlock(&i8253_lock);
write_sequnlock_irq(&xtime_lock);
next prev parent reply other threads:[~2005-06-13 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-13 9:45 [FIX] apm.c: ignore_normal_resume is set to 1 a bit too late Thomas Hood
[not found] ` <20050613222003.2895ac2c.sfr@canb.auug.org.au>
2005-06-13 13:50 ` Thomas Hood [this message]
2005-06-13 21:38 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118670626.7066.84.camel@thanatos \
--to=jdthood@aglu.demon.nl \
--cc=310865-submitter@bugs.debian.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox