Re: [patch] inotify.

Coywolf Qi Hunt
2005-05-09T17:44:49Z

On 5/10/05, Robert Love <rml@novell.com> wrote:
> Below is the latest revision of inotify, against 2.6.12-rc4.
>
> The only functional changes from the last release is a compile warning
> fix for !CONFIG_INOTIFY.

Here's another compile warning, also in the current -mm tree.

> diff -urN linux-2.6.12-rc4/fs/namei.c linux/fs/namei.c
> --- linux-2.6.12-rc4/fs/namei.c 2005-05-09 11:52:48.000000000 -0400
> +++ linux/fs/namei.c 2005-05-09 11:58:52.000000000 -0400

...

> @@ -2172,18 +2174,18 @@
> DQUOT_INIT(old_dir);
> DQUOT_INIT(new_dir);
>
> + old_name = fsnotify_oldname_init(old_dentry->d_name.name);
> +

prodigy:/home/coywolf/2.6.12-rc3-mm3-cy# make fs/namei.o
CC fs/namei.o
/home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c: In function `vfs_rename':
/home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c:2177: warning: passing arg
1 of `fsnotify_oldname_init' from incompatible pointer type

The problem lies in const char *name V.S. const unsigned char *name.

--
Coywolf Qi Hunt