public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, sensors@Stimpy.netroedge.com
Cc: khali@linux-fr.org
Subject: [PATCH] I2C: #include <linux/config.h> cleanup
Date: Tue, 21 Jun 2005 22:17:43 -0700	[thread overview]
Message-ID: <11194174631273@kroah.com> (raw)
In-Reply-To: <11194174633604@kroah.com>

[PATCH] I2C: #include <linux/config.h> cleanup

Hi Alexey,

> Files that don't use CONFIG_* stuff shouldn't include config.h
> Files that use CONFIG_* stuff should include config.h
>
> It's that simple. ;-)

I agree. This won't change anything though, as all drivers include
either device.h or module.h, which in turn include config.h. But you are
still correct, so I approve your patch.

For completeness, I would propose the following on top of your own
patch:

i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
system takes care of it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit a551ef79d9413727f76d22dc47b5b15d1d03073b
tree 4b43e032dc6b6cb5de78ce700b12762ab71483e0
parent f0bb60e7b1a0a26c25d8cbf81dda7afbc8bd2982
author Jean Delvare <khali@linux-fr.org> Sat, 16 Apr 2005 18:49:22 +0200
committer Greg Kroah-Hartman <gregkh@suse.de> Tue, 21 Jun 2005 21:51:53 -0700

 drivers/i2c/busses/i2c-ixp2000.c |    5 -----
 drivers/i2c/busses/i2c-ixp4xx.c  |    5 -----
 2 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/i2c/busses/i2c-ixp2000.c b/drivers/i2c/busses/i2c-ixp2000.c
--- a/drivers/i2c/busses/i2c-ixp2000.c
+++ b/drivers/i2c/busses/i2c-ixp2000.c
@@ -26,11 +26,6 @@
  * 'enabled' to drive the GPIOs.
  */
 
-#include <linux/config.h>
-#ifdef CONFIG_I2C_DEBUG_BUS
-#define DEBUG	1
-#endif
-
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/device.h>
diff --git a/drivers/i2c/busses/i2c-ixp4xx.c b/drivers/i2c/busses/i2c-ixp4xx.c
--- a/drivers/i2c/busses/i2c-ixp4xx.c
+++ b/drivers/i2c/busses/i2c-ixp4xx.c
@@ -26,11 +26,6 @@
  *       that is passed as the platform_data to this driver.
  */
 
-#include <linux/config.h>
-#ifdef CONFIG_I2C_DEBUG_BUS
-#define DEBUG	1
-#endif
-
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/device.h>


  reply	other threads:[~2005-06-22  6:37 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-22  5:16 [GIT PATCH] I2C patches for 2.6.12 Greg KH
2005-06-22  5:17 ` [PATCH] I2C: Kill address ranges in non-sensors i2c chip drivers Greg KH
2005-06-22  5:17   ` [PATCH] I2C: i2c-vid.h: Support for VID to reg conversion Greg KH
2005-06-22  5:17     ` [PATCH] I2C: Merge unused address lists in some video drivers Greg KH
2005-06-22  5:17       ` [PATCH] I2C: rtc8564.c remove duplicate include Greg KH
2005-06-22  5:17         ` [PATCH] I2C: ds1337 1/4 Greg KH
2005-06-22  5:17           ` [PATCH] I2C: mark all functions static in atxp1 driver Greg KH
2005-06-22  5:17             ` [PATCH] I2C: add new " Greg KH
2005-06-22  5:17               ` [PATCH] I2C: ds1337: i2c_transfer() checking Greg KH
2005-06-22  5:17                 ` [PATCH] I2C: ds1337: Make time format consistent with other RTC drivers Greg KH
2005-06-22  5:17                   ` [PATCH] I2C: ds1337 2/4 Greg KH
2005-06-22  5:17                     ` [PATCH] I2C: ds1337 3/4 Greg KH
2005-06-22  5:17                       ` [PATCH] I2C: ds1337: search by bus number Greg KH
2005-06-22  5:17                         ` [PATCH] ds1337 driver works also with ds1339 chip Greg KH
2005-06-22  5:17                           ` [PATCH] ds1337: export ds1337_do_command Greg KH
2005-06-22  5:17                             ` [PATCH] I2C: add new hardware monitor driver: adm9240 Greg KH
2005-06-22  5:17                               ` Greg KH [this message]
2005-06-22  5:17                                 ` [PATCH] I2C: drivers/i2c/*: #include <linux/config.h> cleanup Greg KH
2005-06-22  5:17                                   ` [PATCH] I2C: New hardware monitoring driver: w83627ehf Greg KH
2005-06-22  5:17                                     ` [PATCH] I2C: Fix bugs in the new w83627ehf driver Greg KH
2005-06-22  5:17                                       ` [PATCH] I2C: Add support for the LPC47M15x and LPC47M192 chips to smsc47m1 Greg KH
2005-06-22  5:17                                         ` [PATCH] I2C: Allow for sharing of the interrupt line for i2c-mpc.c Greg KH
2005-06-22  5:17                                           ` [PATCH] Spelling fixes for drivers/i2c Greg KH
2005-06-22  5:17                                             ` [PATCH] I2C: Remove redundancy from i2c-core.c Greg KH
2005-06-22  5:17                                               ` [PATCH] I2C: sysfs names: rename to cpu0_vid, take 3 Greg KH
2005-06-22  5:17                                                 ` [PATCH] I2C: Setting w83627hf fan divisor 128 fails Greg KH
2005-06-22  5:17                                                   ` [PATCH] I2C: remove <linux/delay.h> from via686a Greg KH
2005-06-22  5:17                                                     ` [PATCH] I2C: Kill common macro abuse in chip drivers Greg KH
2005-06-22  5:17                                                       ` [PATCH] I2C: adm9240 driver cleanup Greg KH
2005-06-22  5:17                                                         ` [PATCH] I2C: include of jiffies.h for some i2c drivers Greg KH
2005-06-22  5:17                                                           ` [PATCH] I2C: chips/Kconfig corrections Greg KH
2005-06-22  5:17                                                             ` [PATCH] I2C: driver adm1021: remove die_code Greg KH
2005-06-22  5:17                                                               ` [PATCH] I2C: Coding style cleanups to via686a Greg KH
2005-06-22  5:17                                                                 ` [PATCH] I2C: Spelling fixes for drivers/i2c/algos/i2c-algo-pca.c Greg KH
2005-06-22  5:17                                                                   ` [PATCH] I2C: Kill another macro abuse in via686a Greg KH
2005-06-22  5:17                                                                     ` [PATCH] I2C: fix up some sysfs device attribute file parameters Greg KH
2005-06-22  5:17                                                                       ` [PATCH] I2C: Spelling fixes for drivers/i2c/busses/i2c-parport.c Greg KH
2005-06-22  5:17                                                                         ` [PATCH] I2C: Spelling fixes for drivers/i2c/i2c-core.c Greg KH
2005-06-22  5:17                                                                           ` [PATCH] I2C: Spelling fixes for drivers/i2c/i2c-dev.c Greg KH
2005-06-22  5:17                                                                             ` [PATCH] I2C: add i2c driver for TPS6501x Greg KH
2005-06-22  5:17                                                                               ` [PATCH] i2c: Race fix for i2c-mpc.c Greg KH
2005-06-22  5:17                                                                                 ` [PATCH] I2C: Sensors mailing list has moved Greg KH
2005-06-22  5:17                                                                                   ` [PATCH] I2C: documentation update 1/3 Greg KH
2005-06-22  5:17                                                                                     ` [PATCH] I2C: KConfig update - some EXPERIMENTAL removal Greg KH
2005-06-23 21:12                                                                               ` [PATCH] I2C: add i2c driver for TPS6501x Jean Delvare
2005-06-22  7:37                                               ` [PATCH] I2C: Remove redundancy from i2c-core.c Thomas Schneller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11194174631273@kroah.com \
    --to=gregkh@suse.de \
    --cc=greg@kroah.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox