From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932311AbbI3Pbv (ORCPT ); Wed, 30 Sep 2015 11:31:51 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57693 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752792AbbI3Pbq (ORCPT ); Wed, 30 Sep 2015 11:31:46 -0400 From: Arnd Bergmann To: "Charles (Chas) Williams" <3chas3@gmail.com> Cc: netdev@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-atm-general@lists.sourceforge.net Subject: Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist' Date: Wed, 30 Sep 2015 17:31:28 +0200 Message-ID: <11194729.bUOio0ZMW4@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1443626675.3494.41.camel@gmail.com> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <1443612402-3000775-8-git-send-email-arnd@arndb.de> <1443626675.3494.41.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:x1udD+Z00e1lZ1xbzaz91YGdHHhhZHwxsw5rZlyvWKQ50XvoiRI ILwliFhLhwHLxgaJGr3xoP9sK88DK/FmpkgqQBXiYcQcvNsN3FtrBk/kg/PF/C0oz4/POIC RleHT0CXUpcAFeNoKsBAcstvBr86QaOUJqNfHWl6Ig/VM29reZIhiSWKfPz5WmPnHdQgObT UcHOHcetqjoY6Gb6O8IpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:QnhI545pT/Q=:bqtkmyuaSLf8XjPINZRCN4 EiWtMz9ztGJJEUxLpMI5tZ204eFBlMT9tNcAKOsiF+j+EHKjb+lgGYlcRR4OA8USuzD5AOXje DRP6SFrO07fKYfCbx1MwTCoj4HqbBJLeSpFrIDp72TwIyveo0J83v/6APrLBjajpQ1iXCBmBS 5ZoutPUbKAzNzmPn5IPMDjAreBRXfIwqEYZW/7wW7o0Qal1eejTorLHvhc9PiHvmazwxqDvGL RcFNXnOIxtHdY4ChOCn8suNcGPqvD0z/DKyqeUA1tFdEjZjQRaE4jzZKHT+PC3QuB91DJ/exU qlh3O05DPLc9Qsg1rcw6rI/TyPUxTEVvpNhiM7SxgvJ3vcjuQFolCoDyFbkZFRxp0gAHq6jGC GqPPDtPcWdXsyYvpuWNAd5z8CQCW3EaBEfZ2r0lvvIf3gc88IuJigWWxDdu1iAaseKiqovHhc VZKKSnYGlI/6ENviuCrbtJXuyfZXpIEIwisQR+FExh65n/J4BEw33H0Fe8Up00oj2T+QUTPCb 5TbpyYZZBaPBvrLCt9zR1bF4QbrJ3mYqBg3W8+K+0aYXm9pEYYi1QBkI43gCuWvmEvrjW6iCb lfKPr/d+PXkZLq/daNp5zW1PZ75H8J0rTu09v3tVXBPrC2ZjXf4dab9EGsVdAEtpRvippBVrF 3JoCRFLaoeOEcxzbnwpsE7xDgvCdVKw5U93bPcqjecFI1POlzIkE8y3Nnjdo+eiJV41klB9CX PDAyVHgu2Qps2mRw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 September 2015 11:24:35 Charles Williams wrote: > On Wed, 2015-09-30 at 13:26 +0200, Arnd Bergmann wrote: > > The zatm_t_hist structure is not used anywhere in the kernel, but is > > exported to user space. As we are trying to eliminate uses of time_t > > in the kernel for y2038 compatibility, the current definition triggers > > checking tools because it contains 'struct timeval'. > > > > We can work around this by adding '#ifdef __KERNEL__'. I could not find > > out what the structure is actually used for, so this is the safe choice > > in case there is some user space tool that relies on the definition. > > > > If we are sure that nothing in user space relies on the structure, we > > can instead remove the definition completely. > > It was used by the ZATM_GETHIST ioctl which is long since gone in the > kernel driver. You can just remove this. Perfect, I've updated the patch accordingly, see follow-up mail Thanks, Arnd