public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Cc: rajesh.shah@intel.com
Subject: [PATCH] acpi bridge hotadd: Take the PCI lock when modifying pci bus or device lists
Date: Mon, 27 Jun 2005 22:32:52 -0700	[thread overview]
Message-ID: <11199367722672@kroah.com> (raw)
In-Reply-To: <11199367724120@kroah.com>

[PATCH] acpi bridge hotadd: Take the PCI lock when modifying pci bus or device lists

With root bridge and pci bridge hot-plug, new buses and devices can be added
or removed at run time.  Protect the pci bus and device lists with the pci
lock when doing so.

Signed-off-by: Rajesh Shah <rajesh.shah@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
commit e4ea9bb7e9f177e03a917b1f1213de0315f819ee
tree 482599b5f367e997dfe30590860091bb06219882
parent cc57450f5c044270d2cf1dd437c1850422262109
author Rajesh Shah <rajesh.shah@intel.com> Thu, 28 Apr 2005 00:25:48 -0700
committer Greg Kroah-Hartman <gregkh@suse.de> Mon, 27 Jun 2005 21:52:40 -0700

 drivers/pci/probe.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -374,8 +374,11 @@ struct pci_bus * __devinit pci_add_new_b
 	struct pci_bus *child;
 
 	child = pci_alloc_child_bus(parent, dev, busnr);
-	if (child)
+	if (child) {
+		spin_lock(&pci_bus_lock);
 		list_add_tail(&child->node, &parent->children);
+		spin_unlock(&pci_bus_lock);
+	}
 	return child;
 }
 
@@ -765,7 +768,9 @@ pci_scan_single_device(struct pci_bus *b
 	 * and the bus list for fixup functions, etc.
 	 */
 	INIT_LIST_HEAD(&dev->global_list);
+	spin_lock(&pci_bus_lock);
 	list_add_tail(&dev->bus_list, &bus->devices);
+	spin_unlock(&pci_bus_lock);
 
 	return dev;
 }
@@ -886,7 +891,9 @@ struct pci_bus * __devinit pci_scan_bus_
 		pr_debug("PCI: Bus %04x:%02x already known\n", pci_domain_nr(b), bus);
 		goto err_out;
 	}
+	spin_lock(&pci_bus_lock);
 	list_add_tail(&b->node, &pci_root_buses);
+	spin_unlock(&pci_bus_lock);
 
 	memset(dev, 0, sizeof(*dev));
 	dev->parent = parent;
@@ -928,7 +935,9 @@ class_dev_create_file_err:
 class_dev_reg_err:
 	device_unregister(dev);
 dev_reg_err:
+	spin_lock(&pci_bus_lock);
 	list_del(&b->node);
+	spin_unlock(&pci_bus_lock);
 err_out:
 	kfree(dev);
 	kfree(b);


  reply	other threads:[~2005-06-28  5:58 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-28  5:30 [GIT PATCH] PCI patches for 2.6.12 Greg KH
2005-06-28  5:32 ` [PATCH] PCI Allow OutOfRange PIRQ table address Greg KH
2005-06-28  5:32   ` [PATCH] pci: remove deprecates Greg KH
2005-06-28  5:32     ` Greg KH
2005-06-28  5:32       ` [PATCH] acpi bridge hotadd: Make pcibios_fixup_bus() hot-plug safe Greg KH
2005-06-28  5:32         ` [PATCH] acpi bridge hotadd: ACPI based root bridge hot-add Greg KH
2005-06-28  5:32           ` [PATCH] acpi bridge hotadd: Fix pci_enable_device() for p2p bridges Greg KH
2005-06-28  5:32             ` [PATCH] acpi bridge hotadd: Link newly created pci child bus to its parent on creation Greg KH
2005-06-28  5:32               ` [PATCH] acpi bridge hotadd: Prevent duplicate bus numbers when scanning PCI bridge Greg KH
2005-06-28  5:32                 ` Greg KH [this message]
2005-06-28  5:32                   ` [PATCH] acpi bridge hotadd: Make the PCI remove routines safe for failed hot-plug Greg KH
2005-06-28  5:32                     ` [PATCH] acpi bridge hotadd: Remove hot-plugged devices that could not be allocated resources Greg KH
2005-06-28  5:32                       ` [PATCH] acpi bridge hotadd: Read bridge resources when fixing up the bus Greg KH
2005-06-28  5:32                         ` [PATCH] acpi hotplug: clean up notify handlers on acpiphp unload Greg KH
2005-06-28  5:32                           ` [PATCH] acpi bridge hotadd: Allow ACPI .add and .start operations to be done independently Greg KH
2005-06-28  5:32                             ` [PATCH] acpi hotplug: convert acpiphp to use generic resource code Greg KH
2005-06-28  5:32                               ` [PATCH] acpi bridge hotadd: Export the interface to get PCI id for an ACPI handle Greg KH
2005-06-28  5:32                                 ` [PATCH] acpi hotplug: fix slot power-down problem with acpiphp Greg KH
2005-06-28  5:32                                   ` [PATCH] acpi hotplug: decouple slot power state changes from physical hotplug Greg KH
2005-06-28  5:32                                     ` [PATCH] acpi hotplug: aCPI based root bridge hot-add Greg KH
2005-06-28  5:32                                       ` [PATCH] ACPI based I/O APIC hot-plug: ia64 support Greg KH
2005-06-28  5:32                                         ` [PATCH] ACPI based I/O APIC hot-plug: add interfaces Greg KH
2005-06-28  5:32                                           ` [PATCH] PCI: fix-pci-mmap-on-ppc-and-ppc64.patch Greg KH
2005-06-28  5:32                                             ` [PATCH] ACPI based I/O APIC hot-plug: acpiphp support Greg KH
2005-06-28  5:32                                               ` [PATCH] PCI: DMA bursting advice Greg KH
2005-06-28  5:32                                                 ` [PATCH] cpqphp: fix oops during unload without probe Greg KH
2005-06-28  5:32                                                   ` [PATCH] PCI: clean up the MSI code a bit Greg KH
2005-06-28  5:32                                                     ` [PATCH] PCI: fix up errors after dma bursting patch and CONFIG_PCI=n Greg KH
2005-06-28  5:32                                                       ` [PATCH] PCI: add proper MCFG table parsing to ACPI core Greg KH
2005-06-28  5:32                                                         ` [PATCH] PCI: make drivers use the pci shutdown callback instead of the driver core callback Greg KH
2005-06-28  5:32                                                           ` [PATCH] PCI: use the MCFG table to properly access pci devices (i386) Greg KH
2005-06-28  5:32                                                             ` [PATCH] PCI: use the MCFG table to properly access pci devices (x86-64) Greg KH
2005-06-29 16:33           ` [PATCH] acpi bridge hotadd: ACPI based root bridge hot-add Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11199367722672@kroah.com \
    --to=gregkh@suse.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=rajesh.shah@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox