From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org,
long <tlnguyen@snoqualmie.dp.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Greg KH <greg@kroah.com>,
ak@muc.de, Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com
Subject: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery
Date: Wed, 29 Jun 2005 11:46:58 +1000 [thread overview]
Message-ID: <1120009619.5133.228.camel@gaston> (raw)
In-Reply-To: <20050628235848.GA6376@austin.ibm.com>
On Tue, 2005-06-28 at 18:58 -0500, Linas Vepstas wrote:
> /** e100_io_error_detected() is called when PCI error is detected */
> +static int e100_io_error_detected (struct pci_dev *pdev, enum
> pci_channel_state state)
> +{
> + struct net_device *netdev = pci_get_drvdata(pdev);
> + struct nic *nic = netdev_priv(netdev);
> +
> + mod_timer(&nic->watchdog, jiffies + 30*HZ);
> + e100_down(nic);
> +
> + /* Request a slot reset. */
> + return PCIERR_RESULT_NEED_RESET;
> +}
I'm not sure just "pushing" the watchdog timer to 30sec in the future is
the way to go here. What about netif_stop_queue() or so ?
Ben.
next prev parent reply other threads:[~2005-06-29 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 23:58 [PATCH 4/13]: PCI Err: e100 ethernet driver recovery Linas Vepstas
2005-06-29 1:46 ` Benjamin Herrenschmidt [this message]
2005-06-29 15:59 ` Linas Vepstas
2005-06-29 16:58 ` Andi Kleen
2005-06-29 23:40 ` Benjamin Herrenschmidt
2005-06-30 20:39 ` PCI Power management (was: " Linas Vepstas
2005-06-30 21:07 ` Linas Vepstas
2005-06-30 23:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120009619.5133.228.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@muc.de \
--cc=greg@kroah.com \
--cc=johnrose@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tlnguyen@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox