From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andi Kleen <ak@muc.de>
Cc: Linas Vepstas <linas@austin.ibm.com>,
linux-kernel@vger.kernel.org,
long <tlnguyen@snoqualmie.dp.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Greg KH <greg@kroah.com>, Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com
Subject: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery
Date: Thu, 30 Jun 2005 09:40:07 +1000 [thread overview]
Message-ID: <1120088407.31924.21.camel@gaston> (raw)
In-Reply-To: <20050629165828.GA73550@muc.de>
On Wed, 2005-06-29 at 18:58 +0200, Andi Kleen wrote:
> > Yep, OK. Pushig the timer would in fact break if the device was marked
> > perm disabled.
>
> I think for network drivers you should just write a generic error handler
> (perhaps in net/core/dev.c) that calls the watchdog handler.
> Then all drivers could be easily converted without much code duplication.
Provided the watchdog timer completely reconfigures the device from
reset since the slot will be reset...
Ben.
next prev parent reply other threads:[~2005-06-29 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 23:58 [PATCH 4/13]: PCI Err: e100 ethernet driver recovery Linas Vepstas
2005-06-29 1:46 ` Benjamin Herrenschmidt
2005-06-29 15:59 ` Linas Vepstas
2005-06-29 16:58 ` Andi Kleen
2005-06-29 23:40 ` Benjamin Herrenschmidt [this message]
2005-06-30 20:39 ` PCI Power management (was: " Linas Vepstas
2005-06-30 21:07 ` Linas Vepstas
2005-06-30 23:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120088407.31924.21.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@muc.de \
--cc=greg@kroah.com \
--cc=johnrose@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tlnguyen@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox